You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
2885bd0 doc: unify `datacarriersize` warning with release notes (Lőrinc)
Pull request description:
Follow-up to bitcoin/bitcoin#32406
---
The [release notes](https://github.com/bitcoin/bitcoin/blob/a189d636184b1c28fa4a325b56c1fab8f44527b1/doc/release-notes-32406.md#L1) claim
> [...] marked as deprecated and are expected to be removed in a future release
but the [warning itself](https://github.com/bitcoin/bitcoin/blob/2885bd0e1c4fc863a7f28ff0fd353f5cffb03442/src/init.cpp#L907) claims
> [...] marked as deprecated. They **will** be removed in a future version.
To be less aggressive (since some have objected against this version online) - and to unify the deprecation warning with the release notes - I have changed the warning to communicate our expectation in a friendlier way.
ACKs for top commit:
cedwies:
ACK 2885bd0
ryanofsky:
Code review ACK 2885bd0. I don't think it is good for the release notes and the runtime warning message to say two different things. I'd also be happy if release notes were updated to match the runtime warning, instead of vice versa. Whatever is more accurate is better.
ajtowns:
ACK 2885bd0
kevkevinpal:
ACK [2885bd0](bitcoin/bitcoin@2885bd0)
achow101:
ACK 2885bd0
janb84:
ACK 2885bd0
Zero-1729:
crACK 2885bd0
jonatack:
ACK 2885bd0
hodlinator:
ACK 2885bd0
w0xlt:
ACK bitcoin/bitcoin@2885bd0
optout21:
ACK 2885bd0
Tree-SHA512: a9d2a64ab96b3dd7f3a1a29622930054fd5c56e573bc96330f4ef3327dc024b21b3fbc8a698d17aea7c76f57f0c2ccd6403b2df344ae2f69c645ceb8b6fa54a5
if (args.IsArgSet("-datacarriersize") || args.IsArgSet("-datacarrier")) {
907
-
InitWarning(_("Options '-datacarrier' or '-datacarriersize' are set but are marked as deprecated. They will be removed in a future version."));
907
+
InitWarning(_("Options '-datacarrier' or '-datacarriersize' are set but are marked as deprecated and are expected to be removed in a future version."));
908
908
}
909
909
910
910
// We no longer limit the orphanage based on number of transactions but keep the option to warn users who still have it in their config.
0 commit comments