Skip to content

Commit 467fa89

Browse files
committed
Merge bitcoin/bitcoin#27477: test: add regression tests for #27468 (invalid URI segfaults)
6a77d29 test: add regression tests for #27468 (invalid URI segfaults) (Sebastian Falbesoner) Pull request description: Prior to PR #27468 (commit 11422cc) all call-sites of `GetQueryParameter(...)` in the REST module could trigger a crash. Add missing test cases for all possible code-paths as a regression test, as a foundation for possible follow-up fixes (which aim to resolve this issue in a more general and robust way). ACKs for top commit: stickies-v: ACK 6a77d29 vasild: ACK 6a77d29 Tree-SHA512: b5dd22d7d448f92236575ea950287259795a957a3f8e364682510c7c1ede5f9d67e7daccc5146c8d0817bcb71742d49273801574bd2bb96e44a9ae5a006ac2a7
2 parents 54e07a0 + 6a77d29 commit 467fa89

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/functional/interface_rest.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,8 +278,9 @@ def run_test(self):
278278
assert_equal(json_obj[0]['hash'], bb_hash) # request/response hash should be the same
279279

280280
# Check invalid uri (% symbol at the end of the request)
281-
resp = self.test_rest_request(f"/headers/{bb_hash}%", ret_type=RetType.OBJ, status=400)
282-
assert_equal(resp.read().decode('utf-8').rstrip(), "URI parsing failed, it likely contained RFC 3986 invalid characters")
281+
for invalid_uri in [f"/headers/{bb_hash}%", f"/blockfilterheaders/basic/{bb_hash}%", "/mempool/contents.json?%"]:
282+
resp = self.test_rest_request(invalid_uri, ret_type=RetType.OBJ, status=400)
283+
assert_equal(resp.read().decode('utf-8').rstrip(), "URI parsing failed, it likely contained RFC 3986 invalid characters")
283284

284285
# Compare with normal RPC block response
285286
rpc_block_json = self.nodes[0].getblock(bb_hash)

0 commit comments

Comments
 (0)