clang-tidy: Fix performance-for-range-copy in headers

hebasto · hebasto · commit 48033d43dc30 · 2022-12-16T10:53:55.000Z
See https://clang.llvm.org/extra/clang-tidy/checks/performance/for-range-copy.html
diff --git a/src/psbt.h b/src/psbt.h
@@ -178,7 +178,7 @@ void SerializeHDKeypath(Stream& s, KeyOriginInfo hd_keypath)
 template<typename Stream>
 void SerializeHDKeypaths(Stream& s, const std::map<CPubKey, KeyOriginInfo>& hd_keypaths, CompactSizeWriter type)
 {
-    for (auto keypath_pair : hd_keypaths) {
+    for (const auto& keypath_pair : hd_keypaths) {
         if (!keypath_pair.first.IsValid()) {
             throw std::ios_base::failure("Invalid CPubKey being serialized");
         }

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ void SerializeHDKeypath(Stream& s, KeyOriginInfo hd_keypath)`
`178`	`178`	`template<typename Stream>`
`179`	`179`	`void SerializeHDKeypaths(Stream& s, const std::map<CPubKey, KeyOriginInfo>& hd_keypaths, CompactSizeWriter type)`
`180`	`180`	`{`
`181`		`- for (auto keypath_pair : hd_keypaths) {`
	`181`	`+ for (const auto& keypath_pair : hd_keypaths) {`
`182`	`182`	`if (!keypath_pair.first.IsValid()) {`
`183`	`183`	`throw std::ios_base::failure("Invalid CPubKey being serialized");`
`184`	`184`	`}`