Skip to content

Commit 4cc998c

Browse files
committed
Merge bitcoin/bitcoin#23580: build: patch qt to explicitly define previously implicit header include
8196b0a build: patch qt to explicitly define previously implicit header include (Kittywhiskers Van Gogh) Pull request description: ### Description macOS Monterey has refactored some includes such that implicitly defined headers were no longer exposed and that in turns breaks building Qt on macOS 12. First observed when building on an M1 Pro. See "Additional Reading" for more information. ### Additional Reading * microsoft/vcpkg#21055 (resolved by microsoft/vcpkg@c32ccbb) * ["Add missing macOS header file that was indirectly included before"](https://code.qt.io/cgit/qt/qtbase.git/commit/src/plugins/platforms/cocoa?id=dece6f5840463ae2ddf927d65eb1b3680e34a547) on https://code.qt.io/ ACKs for top commit: hebasto: ACK 8196b0a, verified that the patch is applied cleanly: fanquake: ACK 8196b0a Tree-SHA512: efe6d93edd2e2f68f33a1c353d353c8e7b5aa680733561caa6eb092fd0f68153f8ed1649a61048ef873f6be8041b9ca8e6919d80b947181b6fe4152464e2d383
2 parents 064c729 + 8196b0a commit 4cc998c

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

depends/packages/qt.mk

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ $(package)_patches += support_new_android_ndks.patch fix_android_jni_static.patc
1313
$(package)_patches+= no_sdk_version_check.patch
1414
$(package)_patches+= fix_lib_paths.patch fix_android_pch.patch
1515
$(package)_patches+= qtbase-moc-ignore-gcc-macro.patch fix_limits_header.patch
16+
$(package)_patches+= fix_montery_include.patch
1617

1718
$(package)_qttranslations_file_name=qttranslations-$($(package)_suffix)
1819
$(package)_qttranslations_sha256_hash=577b0668a777eb2b451c61e8d026d79285371597ce9df06b6dee6c814164b7c3
@@ -232,6 +233,7 @@ define $(package)_preprocess_cmds
232233
patch -p1 -i $($(package)_patch_dir)/fix_lib_paths.patch && \
233234
patch -p1 -i $($(package)_patch_dir)/qtbase-moc-ignore-gcc-macro.patch && \
234235
patch -p1 -i $($(package)_patch_dir)/fix_limits_header.patch && \
236+
patch -p1 -i $($(package)_patch_dir)/fix_montery_include.patch && \
235237
mkdir -p qtbase/mkspecs/macx-clang-linux &&\
236238
cp -f qtbase/mkspecs/macx-clang/qplatformdefs.h qtbase/mkspecs/macx-clang-linux/ &&\
237239
cp -f $($(package)_patch_dir)/mac-qmake.conf qtbase/mkspecs/macx-clang-linux/qmake.conf && \
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
From dece6f5840463ae2ddf927d65eb1b3680e34a547
2+
From: Øystein Heskestad <[email protected]>
3+
Date: Wed, 27 Oct 2021 13:07:46 +0200
4+
Subject: [PATCH] Add missing macOS header file that was indirectly included before
5+
6+
See: https://bugreports.qt.io/browse/QTBUG-97855
7+
8+
Upstream Commits:
9+
- Qt 6.2: c884bf138a21dd7320e35cef34d24e22e74d7ce0
10+
11+
diff --git a/qtbase/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h b/qtbase/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h
12+
index e070ba97..07c75b04 100644
13+
--- a/qtbase/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h
14+
+++ b/qtbase/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h
15+
@@ -40,6 +40,7 @@
16+
#ifndef QIOSURFACEGRAPHICSBUFFER_H
17+
#define QIOSURFACEGRAPHICSBUFFER_H
18+
19+
+#include <CoreGraphics/CGColorSpace.h>
20+
#include <qpa/qplatformgraphicsbuffer.h>
21+
#include <private/qcore_mac_p.h>

0 commit comments

Comments
 (0)