Skip to content

Commit 4e9a6f8

Browse files
committed
Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in ConnectTip
fa309dc validation: Log FormatStateMessage on ConnectBlock error in ConnectTip (MarcoFalke) Pull request description: This change additionally logs the validation state on error, which is not logged at all on current master. Before: ``` ERROR: ConnectTip(): ConnectBlock ffffff.... failed ``` After: ``` ERROR: ConnectTip: ConnectBlock ffffff.... failed, bad-cb-amount (code 16) ``` Tree-SHA512: e69ee0266772b3f77c0193c4a959c2444bf1a51259bd29d790cf665582b037997e520c8567f70b36362c071dcfe1a8ebd7c0f2286cf1b842df5731960e7e1ba0
2 parents 888acef + fa309dc commit 4e9a6f8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/validation.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2448,7 +2448,7 @@ bool CChainState::ConnectTip(CValidationState& state, const CChainParams& chainp
24482448
if (!rv) {
24492449
if (state.IsInvalid())
24502450
InvalidBlockFound(pindexNew, state);
2451-
return error("ConnectTip(): ConnectBlock %s failed", pindexNew->GetBlockHash().ToString());
2451+
return error("%s: ConnectBlock %s failed, %s", __func__, pindexNew->GetBlockHash().ToString(), FormatStateMessage(state));
24522452
}
24532453
nTime3 = GetTimeMicros(); nTimeConnectTotal += nTime3 - nTime2;
24542454
LogPrint(BCLog::BENCH, " - Connect total: %.2fms [%.2fs (%.2fms/blk)]\n", (nTime3 - nTime2) * MILLI, nTimeConnectTotal * MICRO, nTimeConnectTotal * MILLI / nBlocksTotal);

0 commit comments

Comments
 (0)