wallet: remove always false 'recalculate' arg from GetCachableAmount

furszy · furszy · commit 4f0ca9bff629 · 2022-07-05T10:10:27.000-03:00
diff --git a/src/wallet/receive.cpp b/src/wallet/receive.cpp
@@ -111,10 +111,10 @@ CAmount TxGetChange(const CWallet& wallet, const CTransaction& tx)
     return nChange;
 }
 
-static CAmount GetCachableAmount(const CWallet& wallet, const CWalletTx& wtx, CWalletTx::AmountType type, const isminefilter& filter, bool recalculate = false)
+static CAmount GetCachableAmount(const CWallet& wallet, const CWalletTx& wtx, CWalletTx::AmountType type, const isminefilter& filter)
 {
     auto& amount = wtx.m_amounts[type];
-    if (recalculate || !amount.m_cached[filter]) {
+    if (!amount.m_cached[filter]) {
         amount.Set(filter, type == CWalletTx::DEBIT ? wallet.GetDebit(*wtx.tx, filter) : TxGetCredit(wallet, *wtx.tx, filter));
         wtx.m_is_cache_empty = false;
     }

Original file line number	Diff line number	Diff line change
`@@ -111,10 +111,10 @@ CAmount TxGetChange(const CWallet& wallet, const CTransaction& tx)`
`111`	`111`	`return nChange;`
`112`	`112`	`}`
`113`	`113`
`114`		`-static CAmount GetCachableAmount(const CWallet& wallet, const CWalletTx& wtx, CWalletTx::AmountType type, const isminefilter& filter, bool recalculate = false)`
	`114`	`+static CAmount GetCachableAmount(const CWallet& wallet, const CWalletTx& wtx, CWalletTx::AmountType type, const isminefilter& filter)`
`115`	`115`	`{`
`116`	`116`	`auto& amount = wtx.m_amounts[type];`
`117`		`- if (recalculate \|\| !amount.m_cached[filter]) {`
	`117`	`+ if (!amount.m_cached[filter]) {`
`118`	`118`	`amount.Set(filter, type == CWalletTx::DEBIT ? wallet.GetDebit(wtx.tx, filter) : TxGetCredit(wallet, wtx.tx, filter));`
`119`	`119`	`wtx.m_is_cache_empty = false;`
`120`	`120`	`}`