Skip to content

Commit 5364dd8

Browse files
committed
test: locked_wallet, skip default fee estimation
Same as we do with the nodes default wallets. No test case on this file is meant to exercise fee estimation.
1 parent be44332 commit 5364dd8

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

test/functional/wallet_fundrawtransaction.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
assert_raises_rpc_error,
2424
count_bytes,
2525
find_vout_for_address,
26+
get_fee,
2627
)
2728
from test_framework.wallet_util import generate_keypair
2829

@@ -570,6 +571,8 @@ def test_locked_wallet(self):
570571
df_wallet = self.nodes[1].get_wallet_rpc(self.default_wallet_name)
571572
self.nodes[1].createwallet(wallet_name="locked_wallet", descriptors=self.options.descriptors)
572573
wallet = self.nodes[1].get_wallet_rpc("locked_wallet")
574+
# This test is not meant to exercise fee estimation. Making sure all txs are sent at a consistent fee rate.
575+
wallet.settxfee(self.min_relay_tx_fee)
573576

574577
# Add some balance to the wallet (this will be reverted at the end of the test)
575578
df_wallet.sendall(recipients=[wallet.getnewaddress()])
@@ -599,8 +602,11 @@ def test_locked_wallet(self):
599602

600603
# Choose input
601604
inputs = wallet.listunspent()
602-
# Deduce fee to produce a changeless transaction
603-
value = inputs[0]["amount"] - Decimal("0.00002200")
605+
606+
# Deduce exact fee to produce a changeless transaction
607+
tx_size = 110 # Total tx size: 110 vbytes, p2wpkh -> p2wpkh. Input 68 vbytes + rest of tx is 42 vbytes.
608+
value = inputs[0]["amount"] - get_fee(tx_size, self.min_relay_tx_fee)
609+
604610
outputs = {self.nodes[0].getnewaddress():value}
605611
rawtx = wallet.createrawtransaction(inputs, outputs)
606612
# fund a transaction that does not require a new key for the change output

0 commit comments

Comments
 (0)