Skip to content

Commit 54865cf

Browse files
committed
Merge #13061: Make tests pass after 2020
3ee4be1 Make tests pass after 2020 (Bernhard M. Wiedemann) Pull request description: Make tests pass after 2020 and also test that 64 bit integers are properly handled Without this patch, the failure was ``` unknown location(0): fatal error: in "rpc_tests/rpc_ban": std::runtime_error: JSON value is not an object as expected test/rpc_tests.cpp(260): last checkpoint ``` I found this when testing reproducible builds for openSUSE Linux packages, building 15 years from now (this is the expected lifespan of today's software) There is 1 other issue in ./src/qt/test/paymentservertests.cpp that fails to verify a cert that expires in 2022 after 10y. ``` QWARN : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant: Payment request: certificate expired or not yet active: QSslCertificate("3", "01", "Ipbt+DxK8RDQd25/5ueXqw==", (), ("Payment Request Test Merchant"), QMap(), QDateTime(2012-12-10 16:37:24.000 UTC Qt::TimeSpec(UTC)), QDateTime(2022-12-08 16:37:24.000 UTC Qt::TimeSpec(UTC))) FAIL! : PaymentServerTests::paymentServerTests() Compared values are not the same ``` Tree-SHA512: d6c49879b6abbddbecc1168ac24c2d4f4ee9949b615607b3e6ba350c415136017f32cd112708791b063a2f2dc1b12f295f4ee55a346bd2128aa6480088d8db48
2 parents 6e67754 + 3ee4be1 commit 54865cf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/test/rpc_tests.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,14 +247,14 @@ BOOST_AUTO_TEST_CASE(rpc_ban)
247247
ar = r.get_array();
248248
BOOST_CHECK_EQUAL(ar.size(), 0U);
249249

250-
BOOST_CHECK_NO_THROW(r = CallRPC(std::string("setban 127.0.0.0/24 add 1607731200 true")));
250+
BOOST_CHECK_NO_THROW(r = CallRPC(std::string("setban 127.0.0.0/24 add 9907731200 true")));
251251
BOOST_CHECK_NO_THROW(r = CallRPC(std::string("listbanned")));
252252
ar = r.get_array();
253253
o1 = ar[0].get_obj();
254254
adr = find_value(o1, "address");
255255
UniValue banned_until = find_value(o1, "banned_until");
256256
BOOST_CHECK_EQUAL(adr.get_str(), "127.0.0.0/24");
257-
BOOST_CHECK_EQUAL(banned_until.get_int64(), 1607731200); // absolute time check
257+
BOOST_CHECK_EQUAL(banned_until.get_int64(), 9907731200); // absolute time check
258258

259259
BOOST_CHECK_NO_THROW(CallRPC(std::string("clearbanned")));
260260

0 commit comments

Comments
 (0)