Skip to content

Commit 55aad5f

Browse files
committed
build: remove stdio.h from header checks
We already use a mix of <cstdio> and stdio.h unconditionally throughout the codebase. Us checking this header also duplicates work already done by autotools. Currently stdio.h is checked for 3 times during a ./configure run, after this change, at least it's only twice.
1 parent b956331 commit 55aad5f

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

build_msvc/bitcoin_config.h.in

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,6 @@
146146
/* Define to 1 if you have the <stdint.h> header file. */
147147
#define HAVE_STDINT_H 1
148148

149-
/* Define to 1 if you have the <stdio.h> header file. */
150-
#define HAVE_STDIO_H 1
151-
152149
/* Define to 1 if you have the <stdlib.h> header file. */
153150
#define HAVE_STDLIB_H 1
154151

configure.ac

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1010,7 +1010,7 @@ if test "$TARGET_OS" = "darwin"; then
10101010
AX_CHECK_LINK_FLAG([-Wl,-bind_at_load], [HARDENED_LDFLAGS="$HARDENED_LDFLAGS -Wl,-bind_at_load"], [], [$LDFLAG_WERROR])
10111011
fi
10121012

1013-
AC_CHECK_HEADERS([endian.h sys/endian.h byteswap.h stdio.h stdlib.h unistd.h sys/types.h sys/stat.h sys/select.h sys/prctl.h sys/sysctl.h vm/vm_param.h sys/vmmeter.h sys/resources.h])
1013+
AC_CHECK_HEADERS([endian.h sys/endian.h byteswap.h stdlib.h unistd.h sys/types.h sys/stat.h sys/select.h sys/prctl.h sys/sysctl.h vm/vm_param.h sys/vmmeter.h sys/resources.h])
10141014

10151015
AC_CHECK_DECLS([getifaddrs, freeifaddrs],[CHECK_SOCKET],,
10161016
[#include <sys/types.h>

0 commit comments

Comments
 (0)