Merge bitcoin/bitcoin#24156: build: Replace which command with command -v

laanwj · laanwj · commit 56a0fbf83653 · 2022-02-02T19:24:37.000+01:00
148b33c build: Replace `which` command with `command -v` (Hennadii Stepanov) Pull request description: On some systems the `which` command can emit messages into stderr. For example, for `debianutils 5.5-1` package in Debian Sid: ``` # which cat /usr/bin/which: this version of `which' is deprecated; use `command -v' in scripts instead. /bin/cat ``` Although such messages are harmless, they could distract developers needlessly (see bitcoin/bitcoin#24056). Fixes bitcoin/bitcoin#24056. ACKs for top commit: dongcarl: Code Review ACK 148b33c laanwj: Code review ACK 148b33c Tree-SHA512: 36ee45d8831afb75a1ba6f8c8491fa5381159a2b86042140ac09037752f74e92d3e725caa793b8e97c36afe03ada0b557eede95df2bec049173c27f32ffc804a
diff --git a/depends/hosts/mingw32.mk b/depends/hosts/mingw32.mk
@@ -1,4 +1,4 @@
-ifneq ($(shell which $(host)-g++-posix),)
+ifneq ($(shell $(SHELL) $(.SHELLFLAGS) "command -v $(host)-g++-posix"),)
 mingw32_CXX := $(host)-g++-posix
 endif
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-ifneq ($(shell which $(host)-g++-posix),)`
	`1`	`+ifneq ($(shell $(SHELL) $(.SHELLFLAGS) "command -v $(host)-g++-posix"),)`
`2`	`2`	`mingw32_CXX := $(host)-g++-posix`
`3`	`3`	`endif`
`4`	`4`