Skip to content

Commit 5759fd1

Browse files
committed
[test] Don't set bypass_limits to true in txvalidation_tests.cpp
AcceptToMemoryPool() is called for an invalid coinbase transaction, so setting bypass_limits to true or false has no impact on the test. The only way that changing bypass_limits from true to false could change the result would be to change the outcome to INVALID(TX_MEMPOOL_POLICY). Since the ATMP call in this test results in INVALID(TX_CONSENSUS) both before and after this change, there is no change in behavior.
1 parent 497c9e2 commit 5759fd1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/test/txvalidation_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ BOOST_FIXTURE_TEST_CASE(tx_mempool_reject_coinbase, TestChain100Setup)
3838

3939
unsigned int initialPoolSize = m_node.mempool->size();
4040
const MempoolAcceptResult result = AcceptToMemoryPool(m_node.chainman->ActiveChainstate(), *m_node.mempool, MakeTransactionRef(coinbaseTx),
41-
true /* bypass_limits */);
41+
false /* bypass_limits */);
4242

4343
BOOST_CHECK(result.m_result_type == MempoolAcceptResult::ResultType::INVALID);
4444

0 commit comments

Comments
 (0)