wallet: migration, remove extra NotifyTransactionChanged call

furszy · furszy · commit 595d50a1032a · 2024-01-06T12:40:20.000-03:00
The wallet is unloaded at the beginning of the migration process,
so no object is listening to the signals.
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -3934,10 +3934,6 @@ bool CWallet::ApplyMigrationData(MigrationData& data, bilingual_str& error)
             error = _("Error: Not all watchonly txs could be deleted");
             return false;
         }
-        // Tell the GUI of each tx
-        for (const uint256& txid : deleted_txids) {
-            NotifyTransactionChanged(txid, CT_UPDATED);
-        }
     }
 
     // Check the address book data in the same way we did for transactions

Original file line number	Diff line number	Diff line change
`@@ -3934,10 +3934,6 @@ bool CWallet::ApplyMigrationData(MigrationData& data, bilingual_str& error)`
`3934`	`3934`	`error = _("Error: Not all watchonly txs could be deleted");`
`3935`	`3935`	`return false;`
`3936`	`3936`	`}`
`3937`		`- // Tell the GUI of each tx`
`3938`		`- for (const uint256& txid : deleted_txids) {`
`3939`		`- NotifyTransactionChanged(txid, CT_UPDATED);`
`3940`		`- }`
`3941`	`3937`	`}`
`3942`	`3938`
`3943`	`3939`	`// Check the address book data in the same way we did for transactions`