test: Remove AddrMan unit test that fails consistency checks

mzumsande · mzumsande · commit 59cc66abb945 · 2023-02-01T10:14:20.000-05:00
Now that Size() performs internal consistency checks,
it will rightfully fail (and assert) when dealing with
a corrupted AddrMan. Therefore remove this check.
diff --git a/src/test/addrman_tests.cpp b/src/test/addrman_tests.cpp
@@ -947,8 +947,6 @@ BOOST_AUTO_TEST_CASE(load_addrman_corrupted)
     } catch (const std::exception&) {
         exceptionThrown = true;
     }
-    // Even though de-serialization failed addrman is not left in a clean state.
-    BOOST_CHECK(addrman1.Size() == 1);
     BOOST_CHECK(exceptionThrown);
 
     // Test that ReadFromStream fails if peers.dat is corrupt

Original file line number	Diff line number	Diff line change
`@@ -947,8 +947,6 @@ BOOST_AUTO_TEST_CASE(load_addrman_corrupted)`
`947`	`947`	`} catch (const std::exception&) {`
`948`	`948`	`exceptionThrown = true;`
`949`	`949`	`}`
`950`		`- // Even though de-serialization failed addrman is not left in a clean state.`
`951`		`- BOOST_CHECK(addrman1.Size() == 1);`
`952`	`950`	`BOOST_CHECK(exceptionThrown);`
`953`	`951`
`954`	`952`	`// Test that ReadFromStream fails if peers.dat is corrupt`