wallet: Remove unnecessary mempool lock in ReacceptWalletTransactions

promag · promag · commit 5b252934362c · 2017-12-11T23:43:31.000Z
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -1713,11 +1713,8 @@ void CWallet::ReacceptWalletTransactions()
     }
 
     // Try to add wallet transactions to memory pool
-    for (std::pair<const int64_t, CWalletTx*>& item : mapSorted)
-    {
+    for (std::pair<const int64_t, CWalletTx*>& item : mapSorted) {
         CWalletTx& wtx = *(item.second);
-
-        LOCK(mempool.cs);
         CValidationState state;
         wtx.AcceptToMemoryPool(maxTxFee, state);
     }

Original file line number	Diff line number	Diff line change
`@@ -1713,11 +1713,8 @@ void CWallet::ReacceptWalletTransactions()`
`1713`	`1713`	`}`
`1714`	`1714`
`1715`	`1715`	`// Try to add wallet transactions to memory pool`
`1716`		`- for (std::pair<const int64_t, CWalletTx*>& item : mapSorted)`
`1717`		`- {`
	`1716`	`+ for (std::pair<const int64_t, CWalletTx*>& item : mapSorted) {`
`1718`	`1717`	`CWalletTx& wtx = *(item.second);`
`1719`		`-`
`1720`		`- LOCK(mempool.cs);`
`1721`	`1718`	`CValidationState state;`
`1722`	`1719`	`wtx.AcceptToMemoryPool(maxTxFee, state);`
`1723`	`1720`	`}`