Skip to content

Commit 637d8bc

Browse files
committed
Change FILE_CHAR_BLOCKLIST to FILE_CHARS_DISALLOWED
Blocklist is ambiguous. It could mean a list of blocks. Example: "blocknotify" in the same file refers to Bitcoin blocks.
1 parent 68d1f16 commit 637d8bc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/functional/feature_notifications.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
# Windows disallow control characters (0-31) and /\?%:|"<>
1919
FILE_CHAR_START = 32 if os.name == 'nt' else 1
2020
FILE_CHAR_END = 128
21-
FILE_CHAR_BLOCKLIST = '/\\?%*:|"<>' if os.name == 'nt' else '/'
21+
FILE_CHARS_DISALLOWED = '/\\?%*:|"<>' if os.name == 'nt' else '/'
2222

2323

2424
def notify_outputname(walletname, txid):
@@ -31,7 +31,7 @@ def set_test_params(self):
3131
self.setup_clean_chain = True
3232

3333
def setup_network(self):
34-
self.wallet = ''.join(chr(i) for i in range(FILE_CHAR_START, FILE_CHAR_END) if chr(i) not in FILE_CHAR_BLOCKLIST)
34+
self.wallet = ''.join(chr(i) for i in range(FILE_CHAR_START, FILE_CHAR_END) if chr(i) not in FILE_CHARS_DISALLOWED)
3535
self.alertnotify_dir = os.path.join(self.options.tmpdir, "alertnotify")
3636
self.blocknotify_dir = os.path.join(self.options.tmpdir, "blocknotify")
3737
self.walletnotify_dir = os.path.join(self.options.tmpdir, "walletnotify")

0 commit comments

Comments
 (0)