Skip to content

Commit 65b2650

Browse files
committed
Merge bitcoin/bitcoin#32746: test: remove unnecessary m_best_header setting hack in feature_assumeutxo.py
206bc05 test: remove unnecessary m_best_header setting hack in feature_assumeutxo.py (Sebastian Falbesoner) Pull request description: The mentioned bug (issue #26245) has been fixed in PR #30666, so the workaround is not needed anymore. ACKs for top commit: fjahr: ACK 206bc05 janb84: ACK 206bc05 mzumsande: utACK 206bc05 Tree-SHA512: 92ad6c09c80318a02e00d8c2a4ca1ec8a6caa6aa310916ff705871c91fe5c960c15ed394ead8ce9c7466b592dba176aa87a635b3228ddc93f57082124f04613f
2 parents 3e81684 + 206bc05 commit 65b2650

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

test/functional/feature_assumeutxo.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -484,12 +484,6 @@ def check_dump_output(output):
484484
dump_output5 = n0.dumptxoutset('utxos5.dat', rollback=prev_snap_hash)
485485
assert_equal(sha256sum_file(dump_output4['path']), sha256sum_file(dump_output5['path']))
486486

487-
# TODO: This is a hack to set m_best_header to the correct value after
488-
# dumptxoutset/reconsiderblock. Otherwise the wrong error messages are
489-
# returned in following tests. It can be removed once this bug is
490-
# fixed. See also https://github.com/bitcoin/bitcoin/issues/26245
491-
self.restart_node(0, ["-reindex"])
492-
493487
# Ensure n0 is back at the tip
494488
assert_equal(n0.getblockchaininfo()["blocks"], FINAL_HEIGHT)
495489

0 commit comments

Comments
 (0)