Merge #9575: Remove unused, non-working RPC PostCommand signal

laanwj · laanwj · commit 6805c4112cfd · 2017-03-09T10:01:03.000+01:00
54fae05 Remove unreachable code (g_rpcSignals.PostCommand) (practicalswift) Tree-SHA512: b416d63ffa1c35fa0434b6bc0a930ae1b04919a12114ef65154ce4621aa43d744eb4fc515f48eac2e96c0f528cedb4cdbe2349952d215c2c74e900a63e155e0a
diff --git a/src/rpc/server.cpp b/src/rpc/server.cpp
@@ -40,7 +40,6 @@ static struct CRPCSignals
     boost::signals2::signal<void ()> Started;
     boost::signals2::signal<void ()> Stopped;
     boost::signals2::signal<void (const CRPCCommand&)> PreCommand;
-    boost::signals2::signal<void (const CRPCCommand&)> PostCommand;
 } g_rpcSignals;
 
 void RPCServer::OnStarted(boost::function<void ()> slot)
@@ -58,11 +57,6 @@ void RPCServer::OnPreCommand(boost::function<void (const CRPCCommand&)> slot)
     g_rpcSignals.PreCommand.connect(boost::bind(slot, _1));
 }
 
-void RPCServer::OnPostCommand(boost::function<void (const CRPCCommand&)> slot)
-{
-    g_rpcSignals.PostCommand.connect(boost::bind(slot, _1));
-}
-
 void RPCTypeCheck(const UniValue& params,
                   const std::list<UniValue::VType>& typesExpected,
                   bool fAllowNull)
@@ -491,8 +485,6 @@ UniValue CRPCTable::execute(const JSONRPCRequest &request) const
     {
         throw JSONRPCError(RPC_MISC_ERROR, e.what());
     }
-
-    g_rpcSignals.PostCommand(*pcmd);
 }
 
 std::vector<std::string> CRPCTable::listCommands() const

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,6 @@ static struct CRPCSignals`
`40`	`40`	`boost::signals2::signal<void ()> Started;`
`41`	`41`	`boost::signals2::signal<void ()> Stopped;`
`42`	`42`	`boost::signals2::signal<void (const CRPCCommand&)> PreCommand;`
`43`		`- boost::signals2::signal<void (const CRPCCommand&)> PostCommand;`
`44`	`43`	`} g_rpcSignals;`
`45`	`44`
`46`	`45`	`void RPCServer::OnStarted(boost::function<void ()> slot)`
`@@ -58,11 +57,6 @@ void RPCServer::OnPreCommand(boost::function<void (const CRPCCommand&)> slot)`
`58`	`57`	`g_rpcSignals.PreCommand.connect(boost::bind(slot, _1));`
`59`	`58`	`}`
`60`	`59`
`61`		`-void RPCServer::OnPostCommand(boost::function<void (const CRPCCommand&)> slot)`
`62`		`-{`
`63`		`- g_rpcSignals.PostCommand.connect(boost::bind(slot, _1));`
`64`		`-}`
`65`		`-`
`66`	`60`	`void RPCTypeCheck(const UniValue& params,`
`67`	`61`	`const std::list<UniValue::VType>& typesExpected,`
`68`	`62`	`bool fAllowNull)`
`@@ -491,8 +485,6 @@ UniValue CRPCTable::execute(const JSONRPCRequest &request) const`
`491`	`485`	`{`
`492`	`486`	`throw JSONRPCError(RPC_MISC_ERROR, e.what());`
`493`	`487`	`}`
`494`		`-`
`495`		`- g_rpcSignals.PostCommand(*pcmd);`
`496`	`488`	`}`
`497`	`489`
`498`	`490`	`std::vector<std::string> CRPCTable::listCommands() const`