|
| 1 | +// Copyright (c) 2021 The Bitcoin Core developers |
| 2 | +// Distributed under the MIT software license, see the accompanying |
| 3 | +// file COPYING or http://www.opensource.org/licenses/mit-license.php. |
| 4 | + |
| 5 | +#include <consensus/validation.h> |
| 6 | +#include <key_io.h> |
| 7 | +#include <policy/packages.h> |
| 8 | +#include <policy/policy.h> |
| 9 | +#include <primitives/transaction.h> |
| 10 | +#include <script/script.h> |
| 11 | +#include <script/standard.h> |
| 12 | +#include <test/util/setup_common.h> |
| 13 | +#include <validation.h> |
| 14 | + |
| 15 | +#include <boost/test/unit_test.hpp> |
| 16 | + |
| 17 | +BOOST_AUTO_TEST_SUITE(txpackage_tests) |
| 18 | + |
| 19 | +// Create placeholder transactions that have no meaning. |
| 20 | +inline CTransactionRef create_placeholder_tx(size_t num_inputs, size_t num_outputs) |
| 21 | +{ |
| 22 | + CMutableTransaction mtx = CMutableTransaction(); |
| 23 | + mtx.vin.resize(num_inputs); |
| 24 | + mtx.vout.resize(num_outputs); |
| 25 | + auto random_script = CScript() << ToByteVector(InsecureRand256()) << ToByteVector(InsecureRand256()); |
| 26 | + for (size_t i{0}; i < num_inputs; ++i) { |
| 27 | + mtx.vin[i].prevout.hash = InsecureRand256(); |
| 28 | + mtx.vin[i].prevout.n = 0; |
| 29 | + mtx.vin[i].scriptSig = random_script; |
| 30 | + } |
| 31 | + for (size_t o{0}; o < num_outputs; ++o) { |
| 32 | + mtx.vout[o].nValue = 1 * CENT; |
| 33 | + mtx.vout[o].scriptPubKey = random_script; |
| 34 | + } |
| 35 | + return MakeTransactionRef(mtx); |
| 36 | +} |
| 37 | + |
| 38 | +BOOST_FIXTURE_TEST_CASE(package_validation_tests, TestChain100Setup) |
| 39 | +{ |
| 40 | + LOCK(cs_main); |
| 41 | + unsigned int initialPoolSize = m_node.mempool->size(); |
| 42 | + |
| 43 | + // Parent and Child Package |
| 44 | + CKey parent_key; |
| 45 | + parent_key.MakeNewKey(true); |
| 46 | + CScript parent_locking_script = GetScriptForDestination(PKHash(parent_key.GetPubKey())); |
| 47 | + auto mtx_parent = CreateValidMempoolTransaction(/* input_transaction */ m_coinbase_txns[0], /* vout */ 0, |
| 48 | + /* input_height */ 0, /* input_signing_key */ coinbaseKey, |
| 49 | + /* output_destination */ parent_locking_script, |
| 50 | + /* output_amount */ CAmount(49 * COIN), /* submit */ false); |
| 51 | + CTransactionRef tx_parent = MakeTransactionRef(mtx_parent); |
| 52 | + |
| 53 | + CKey child_key; |
| 54 | + child_key.MakeNewKey(true); |
| 55 | + CScript child_locking_script = GetScriptForDestination(PKHash(child_key.GetPubKey())); |
| 56 | + auto mtx_child = CreateValidMempoolTransaction(/* input_transaction */ tx_parent, /* vout */ 0, |
| 57 | + /* input_height */ 101, /* input_signing_key */ parent_key, |
| 58 | + /* output_destination */ child_locking_script, |
| 59 | + /* output_amount */ CAmount(48 * COIN), /* submit */ false); |
| 60 | + CTransactionRef tx_child = MakeTransactionRef(mtx_child); |
| 61 | + const auto result_parent_child = ProcessNewPackage(m_node.chainman->ActiveChainstate(), *m_node.mempool, {tx_parent, tx_child}, /* test_accept */ true); |
| 62 | + BOOST_CHECK_MESSAGE(result_parent_child.m_state.IsValid(), |
| 63 | + "Package validation unexpectedly failed: " << result_parent_child.m_state.GetRejectReason()); |
| 64 | + auto it_parent = result_parent_child.m_tx_results.find(tx_parent->GetWitnessHash()); |
| 65 | + auto it_child = result_parent_child.m_tx_results.find(tx_child->GetWitnessHash()); |
| 66 | + BOOST_CHECK(it_parent != result_parent_child.m_tx_results.end()); |
| 67 | + BOOST_CHECK_MESSAGE(it_parent->second.m_state.IsValid(), |
| 68 | + "Package validation unexpectedly failed: " << it_parent->second.m_state.GetRejectReason()); |
| 69 | + BOOST_CHECK(it_child != result_parent_child.m_tx_results.end()); |
| 70 | + BOOST_CHECK_MESSAGE(it_child->second.m_state.IsValid(), |
| 71 | + "Package validation unexpectedly failed: " << it_child->second.m_state.GetRejectReason()); |
| 72 | + |
| 73 | + // Packages can't have more than 25 transactions. |
| 74 | + Package package_too_many; |
| 75 | + package_too_many.reserve(MAX_PACKAGE_COUNT + 1); |
| 76 | + for (size_t i{0}; i < MAX_PACKAGE_COUNT + 1; ++i) { |
| 77 | + package_too_many.emplace_back(create_placeholder_tx(1, 1)); |
| 78 | + } |
| 79 | + auto result_too_many = ProcessNewPackage(m_node.chainman->ActiveChainstate(), *m_node.mempool, package_too_many, /* test_accept */ true); |
| 80 | + BOOST_CHECK(result_too_many.m_state.IsInvalid()); |
| 81 | + BOOST_CHECK_EQUAL(result_too_many.m_state.GetResult(), PackageValidationResult::PCKG_POLICY); |
| 82 | + BOOST_CHECK_EQUAL(result_too_many.m_state.GetRejectReason(), "package-too-many-transactions"); |
| 83 | + |
| 84 | + // Packages can't have a total size of more than 101KvB. |
| 85 | + CTransactionRef large_ptx = create_placeholder_tx(150, 150); |
| 86 | + Package package_too_large; |
| 87 | + auto size_large = GetVirtualTransactionSize(*large_ptx); |
| 88 | + size_t total_size{0}; |
| 89 | + while (total_size <= MAX_PACKAGE_SIZE * 1000) { |
| 90 | + package_too_large.push_back(large_ptx); |
| 91 | + total_size += size_large; |
| 92 | + } |
| 93 | + BOOST_CHECK(package_too_large.size() <= MAX_PACKAGE_COUNT); |
| 94 | + auto result_too_large = ProcessNewPackage(m_node.chainman->ActiveChainstate(), *m_node.mempool, package_too_large, /* test_accept */ true); |
| 95 | + BOOST_CHECK(result_too_large.m_state.IsInvalid()); |
| 96 | + BOOST_CHECK_EQUAL(result_too_large.m_state.GetResult(), PackageValidationResult::PCKG_POLICY); |
| 97 | + BOOST_CHECK_EQUAL(result_too_large.m_state.GetRejectReason(), "package-too-large"); |
| 98 | + |
| 99 | + // A single, giant transaction submitted through ProcessNewPackage fails on single tx policy. |
| 100 | + CTransactionRef giant_ptx = create_placeholder_tx(999, 999); |
| 101 | + BOOST_CHECK(GetVirtualTransactionSize(*giant_ptx) > MAX_PACKAGE_SIZE * 1000); |
| 102 | + auto result_single_large = ProcessNewPackage(m_node.chainman->ActiveChainstate(), *m_node.mempool, {giant_ptx}, /* test_accept */ true); |
| 103 | + BOOST_CHECK(result_single_large.m_state.IsInvalid()); |
| 104 | + BOOST_CHECK_EQUAL(result_single_large.m_state.GetResult(), PackageValidationResult::PCKG_TX); |
| 105 | + BOOST_CHECK_EQUAL(result_single_large.m_state.GetRejectReason(), "transaction failed"); |
| 106 | + auto it_giant_tx = result_single_large.m_tx_results.find(giant_ptx->GetWitnessHash()); |
| 107 | + BOOST_CHECK(it_giant_tx != result_single_large.m_tx_results.end()); |
| 108 | + BOOST_CHECK_EQUAL(it_giant_tx->second.m_state.GetRejectReason(), "tx-size"); |
| 109 | + |
| 110 | + // Check that mempool size hasn't changed. |
| 111 | + BOOST_CHECK_EQUAL(m_node.mempool->size(), initialPoolSize); |
| 112 | +} |
| 113 | +BOOST_AUTO_TEST_SUITE_END() |
0 commit comments