Skip to content

Commit 688c613

Browse files
committed
Merge bitcoin/bitcoin#27907: bench: bugfix, disable birth time block skip for wallet_create_tx.cpp
a72af2e bench: disable birth time block skip for wallet_create_tx.cpp (furszy) Pull request description: As the benchmarks inside `wallet_create_tx.cpp` assert the wallet balance at the end, they require all blocks to be scanned by the wallet. So, we need to ensure that no blocks are skipped by the recently added wallet birth time functionality. This just means setting the wallet birth time to the genesis block time. So the wallet is always older than any new block. ACKs for top commit: achow101: ACK a72af2e hernanmarino: ACK a72af2e TheCharlatan: ACK a72af2e Tree-SHA512: d3148659bd633d20978736e1292e3456a2c6dd2b6c8f60625a4160e16818d923487c889237eb3f34693f7dd78b7d124b89afdc56e4c9fad370026d0733ef1e08
2 parents c2316b1 + a72af2e commit 688c613

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/bench/wallet_create_tx.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ static void WalletCreateTx(benchmark::Bench& bench, const OutputType output_type
8383
{
8484
const auto test_setup = MakeNoLogFileContext<const TestingSetup>();
8585

86+
// Set clock to genesis block, so the descriptors/keys creation time don't interfere with the blocks scanning process.
87+
SetMockTime(test_setup->m_node.chainman->GetParams().GenesisBlock().nTime);
8688
CWallet wallet{test_setup->m_node.chain.get(), "", CreateMockableWalletDatabase()};
8789
{
8890
LOCK(wallet.cs_wallet);
@@ -136,6 +138,8 @@ static void WalletCreateTx(benchmark::Bench& bench, const OutputType output_type
136138
static void AvailableCoins(benchmark::Bench& bench, const std::vector<OutputType>& output_type)
137139
{
138140
const auto test_setup = MakeNoLogFileContext<const TestingSetup>();
141+
// Set clock to genesis block, so the descriptors/keys creation time don't interfere with the blocks scanning process.
142+
SetMockTime(test_setup->m_node.chainman->GetParams().GenesisBlock().nTime);
139143
CWallet wallet{test_setup->m_node.chain.get(), "", CreateMockableWalletDatabase()};
140144
{
141145
LOCK(wallet.cs_wallet);

0 commit comments

Comments
 (0)