Skip to content

Commit 6d11f19

Browse files
author
MarcoFalke
committed
Merge bitcoin/bitcoin#26658: test: Fix backwards compatibility intermittent failure
c29bff5 test: Fix backwards compatibility intermittent failure (Aurèle Oulès) Pull request description: Fixes #24400. See bitcoin/bitcoin#24400 (comment) to reproduce the failure. As MarcoFalke suggested in bitcoin/bitcoin#24400 (comment), it can happen that the wallet is not fully flushed before being copied over to the other node. Fixed by unloading the wallet before copying the file. ACKs for top commit: Sjors: utACK c29bff5 Tree-SHA512: ea93b859878873d07fa44ccb1c5b4c1b1014be8568dc2b9bbef02bb7a9230fefa7a71b149eb553870d3f4e986263342ea4f996fa0221098a2244f38952100471
2 parents 3eaf7be + c29bff5 commit 6d11f19

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/functional/feature_backwards_compatibility.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,7 @@ def run_test(self):
274274
assert_equal(info["desc"], descsum_create(descriptor))
275275

276276
# Now copy that same wallet back to 0.16 to make sure no automatic upgrade breaks it
277+
node_master.unloadwallet("u1_v16")
277278
os.remove(os.path.join(node_v16_wallets_dir, "wallets/u1_v16"))
278279
shutil.copyfile(
279280
os.path.join(node_master_wallets_dir, "u1_v16"),

0 commit comments

Comments
 (0)