Skip to content

Commit 6d20f4b

Browse files
committed
Merge bitcoin/bitcoin#25178: doc: remove passing --disable-external-signer in OpenBSD build guide
9ecb0a3 doc: remove passing `--disable-external-signer` in OpenBSD build guide (Sebastian Falbesoner) Pull request description: Since we have a Boost.Process usage check in the build system (#24254, commit abc057c), passing the option `--disable-external-signer` explicitly is not needed anymore on OpenBSD; the configure script will automatically detect that including `<boost/process.hpp>` leads to a compile error and disable external signer support accordingly: ``` $ ./configure MAKE=gmake ... checking whether Boost.Process can be used... no ... Options used to compile and link: external signer = no ... $ ./configure --enable-external-signer MAKE=gmake ... checking whether Boost.Process can be used... no configure: error: External signing is not supported for this Boost version ``` The PR basically reverts #22335 but keeps the part mentioning that external signer support is not available on OpenBSD. Also bumps the guide to version 7.1 (released [about a month ago](https://www.openbsd.org/71.html)), where I could verify that the instructions are still accurate. ACKs for top commit: fanquake: ACK 9ecb0a3 Tree-SHA512: a5f7e89a5a78f062a06e0047802c42ad49d89e0f0afb963886caa684966ea2e9c8a660320eedd98a5aa5eee0a9c2bb8bf7f5772338c4b49738a69c00e9367a15
2 parents b0e16eb + 9ecb0a3 commit 6d20f4b

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

doc/build-openbsd.md

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# OpenBSD Build Guide
22

3-
**Updated for OpenBSD [7.0](https://www.openbsd.org/70.html)**
3+
**Updated for OpenBSD [7.1](https://www.openbsd.org/71.html)**
44

55
This guide describes how to build bitcoind, command-line utilities, and GUI on OpenBSD.
66

@@ -78,27 +78,24 @@ export AUTOMAKE_VERSION=1.16
7878

7979
### 1. Configuration
8080

81-
Note that building with external signer support currently fails on OpenBSD,
82-
hence you have to explicitly disable it by passing the parameter
83-
`--disable-external-signer` to the configure script. The feature requires the
84-
header-only library boost::process, which is available on OpenBSD, but contains
85-
certain system calls and preprocessor defines like `waitid()` and `WEXITED` that
86-
are not available.
81+
Note that external signer support is currently not available on OpenBSD, since
82+
the used header-only library Boost.Process fails to compile (certain system
83+
calls and preprocessor defines like `waitid()` and `WEXITED` are missing).
8784

8885
There are many ways to configure Bitcoin Core, here are a few common examples:
8986

9087
##### Descriptor Wallet and GUI:
9188
This enables the GUI and descriptor wallet support, assuming `sqlite` and `qt5` are installed.
9289

9390
```bash
94-
./configure --disable-external-signer MAKE=gmake
91+
./configure MAKE=gmake
9592
```
9693

9794
##### Descriptor & Legacy Wallet. No GUI:
9895
This enables support for both wallet types and disables the GUI:
9996

10097
```bash
101-
./configure --disable-external-signer --with-gui=no \
98+
./configure --with-gui=no \
10299
BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" \
103100
BDB_CFLAGS="-I${BDB_PREFIX}/include" \
104101
MAKE=gmake

0 commit comments

Comments
 (0)