Skip to content

Commit 6f36624

Browse files
committed
Merge bitcoin/bitcoin#30150: doc: Correct pull request prefix for scripts and tools
fa3e115 doc: Correct pull request prefix for scripts and tools (MarcoFalke) Pull request description: `script` is confusing, because in the context of Bitcoin, it usually means Bitcoin script (c.f. `CScript` in `script.h`, or pull requests such as bitcoin/bitcoin#27122 using the prefix). This could be fixed by renaming it to `scripts` (with a plural `s` at the end), however, looking at the current usage `contrib` and `cli` seem more common (bitcoin/bitcoin#29687, bitcoin/bitcoin#26953, bitcoin/bitcoin#26584, bitcoin/bitcoin#24864, bitcoin/bitcoin#30074, bitcoin/bitcoin#29433 ...) ACKs for top commit: fanquake: ACK fa3e115 willcl-ark: ACK fa3e115 hebasto: ACK fa3e115. theuni: ACK fa3e115 Tree-SHA512: fb3a3892ca5f859e590c8a620350c397ef1f9eafd9e174c70ef50095d401a396758d6c93ad41888da8025c41e25e691f30c18f9e974af13597f2266bb2c53b6d
2 parents 93bec6e + fa3e115 commit 6f36624

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ the pull request affects. Valid areas as:
149149
- `net` or `p2p` for changes to the peer-to-peer network code
150150
- `refactor` for structural changes that do not change behavior
151151
- `rpc`, `rest` or `zmq` for changes to the RPC, REST or ZMQ APIs
152-
- `script` for changes to the scripts and tools
152+
- `contrib` or `cli` for changes to the scripts and tools
153153
- `test`, `qa` or `ci` for changes to the unit tests, QA tests or CI code
154154
- `util` or `lib` for changes to the utils or libraries
155155
- `wallet` for changes to the wallet code

0 commit comments

Comments
 (0)