Skip to content

Commit 6f5eb7a

Browse files
committed
Merge bitcoin/bitcoin#27226: test: Use self.wait_until over wait_until_helper
faa6715 test: Use self.wait_until over wait_until_helper (MarcoFalke) Pull request description: `wait_until_helper` is a "private" helper, not intended to be used directly, because it doesn't scale the timeout with the timeout factor. Fix this by replacing it with a call to `self.wait_until`, which does the scaling. ACKs for top commit: theStack: Code-review ACK faa6715 Tree-SHA512: 70705f309f83ffd6ea5d090218195d05b868624d909106863372f861138b5a70887070b25beb25044ae1b44250345e45c9cc11191ae7aeca2ad37801a0f62f61
2 parents 6e662a8 + faa6715 commit 6f5eb7a

File tree

1 file changed

+1
-1
lines changed
  • test/functional/test_framework

1 file changed

+1
-1
lines changed

test/functional/test_framework/p2p.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ def test_function():
464464

465465
def wait_for_connect(self, timeout=60):
466466
test_function = lambda: self.is_connected
467-
wait_until_helper(test_function, timeout=timeout, lock=p2p_lock)
467+
self.wait_until(test_function, timeout=timeout, check_connected=False)
468468

469469
def wait_for_disconnect(self, timeout=60):
470470
test_function = lambda: not self.is_connected

0 commit comments

Comments
 (0)