refactor: use strprintf for creating unknown-service-flag string

theStack · theStack · commit 706c8e096978 · 2022-08-20T15:11:28.000+02:00
No need to use a stringstream here.
diff --git a/src/protocol.cpp b/src/protocol.cpp
@@ -199,12 +199,7 @@ static std::string serviceFlagToStr(size_t bit)
     // Not using default, so we get warned when a case is missing
     }
 
-    std::ostringstream stream;
-    stream.imbue(std::locale::classic());
-    stream << "UNKNOWN[";
-    stream << "2^" << bit;
-    stream << "]";
-    return stream.str();
+    return strprintf("UNKNOWN[2^%u]", bit);
 }
 
 std::vector<std::string> serviceFlagsToStr(uint64_t flags)

Original file line number	Diff line number	Diff line change
`@@ -199,12 +199,7 @@ static std::string serviceFlagToStr(size_t bit)`
`199`	`199`	`// Not using default, so we get warned when a case is missing`
`200`	`200`	`}`
`201`	`201`
`202`		`- std::ostringstream stream;`
`203`		`- stream.imbue(std::locale::classic());`
`204`		`- stream << "UNKNOWN[";`
`205`		`- stream << "2^" << bit;`
`206`		`- stream << "]";`
`207`		`- return stream.str();`
	`202`	`+ return strprintf("UNKNOWN[2^%u]", bit);`
`208`	`203`	`}`
`209`	`204`
`210`	`205`	`std::vector<std::string> serviceFlagsToStr(uint64_t flags)`