Skip to content

Commit 711ce2e

Browse files
committed
Merge bitcoin/bitcoin#23778: release: Guix 1.4.0 & GCC 10.3
84f9931 guix: use upstream python-requests (2.26.0) (fanquake) 187dc1e build: use python-asn1crypto from upstream (fanquake) b1e8f0b guix: use uptream nsis-x86_64 (fanquake) 3ccfba1 guix: use GCC 10 (over GCC 8) to build releases (fanquake) Pull request description: Guix's `core-updates-frozen` branch has been merged back into `master`, and a [`version-1.4.0`](https://git.savannah.gnu.org/cgit/guix.git/log/?h=version-1.4.0) branch has been created. This is great, as it means the next Guix release is on the horizon, and it contains a number of changes I'd like to take advantage of. In particular, is migrating the version of GCC we use for releases from GCC 8 to GCC 10.3.0 (which is also the new Guix default GCC). This is my preferred method of unblocking progress in #20744, which is currently stalled due to support for `std::filesystem` for Windows not arriving in GCC until version 9, whereas it's usable on Linux starting with GCC 8. The current set of changes in that PR [attempt to backport support](bitcoin/bitcoin@9604eda) for `std::filesystem`, for Windows, to GCC 8, similar to what is currently done by Debian, however that is somewhat convoluted, and using GCC 10 with our current Guix version would require updating at least one Guix patch to GCC, so is not completely straightforward either. Other changes included here: * Dropping our `--no-*` patch for mingw binutils ld, as we can take advantage of the `--disable-*` flags that are now available in binutlils 2.37. The security check tests are updated accordingly. * Dropping our current patch for NSIS, as it's been integrated upstream, however given we are building v3.05, we need a different one (NSIS-Dev/nsis@229b613) for compiling against GCC 10. * Removing our `python-asn1crypto` package definition, as an identical package is available in Guix. Over time we should look at trying to get the rest of the python packages we define here upstreamed. * Adding a patch for `python-elfsteem` to fix an issue in the example code when using Python 3.9+. * Our base glibc (`2.24`) now inherits from glibc-2.31. Guix has removed packages of glibc < 2.29, and the current version of glibc is `2.33`. However glibc-2.31 is the newest version that still contains a workaround for installing sunrpc data, which we need, so inheriting from that version seemed like the most straightforward solution. * As mentioned, Guix has removed glibcs < 2.29, so we add our own package definition for glibc 2.27, which we use for our RISC-V toolchain (also inheriting from 2.31). The guix commit hash currently points to the head of the `version-1.4.0` branch. This can be updated to an official release tag when one is available. Looking for Concept ACKs on migrating to using GCC 10.3 for building releases. Keeping in mind issues like #20005, however that particular bug should be fixed in GCC 10.3.0+, according to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189. Guix Builds: ```bash bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum ea56ef38bd94dbcb11b9d10e2f10c205109daad03fea4313f79892fc497ba68d guix-build-84f9931cb449/output/aarch64-linux-gnu/SHA256SUMS.part 01123ab23e5a09dc06a897837389e859d302ba2b18fbe827936ec8983765e7df guix-build-84f9931cb449/output/aarch64-linux-gnu/bitcoin-84f9931cb449-aarch64-linux-gnu-debug.tar.gz 7a24e25c2237e5aeb14508b91c5c6954572814e1767e892c164494f32d73b0c0 guix-build-84f9931cb449/output/aarch64-linux-gnu/bitcoin-84f9931cb449-aarch64-linux-gnu.tar.gz 0e1dba0233da1f487222b128964980d50393e61a6971bcf4c71951c29fdf3993 guix-build-84f9931cb449/output/arm-linux-gnueabihf/SHA256SUMS.part 8cd4c6f42abc81427f1d2500f86daced2a4ee78882dd9d03b5a0211a1d96306e guix-build-84f9931cb449/output/arm-linux-gnueabihf/bitcoin-84f9931cb449-arm-linux-gnueabihf-debug.tar.gz c180db6bffb1a54b6dc65929d86d5eba9adf876a28ad320590ed230233e57299 guix-build-84f9931cb449/output/arm-linux-gnueabihf/bitcoin-84f9931cb449-arm-linux-gnueabihf.tar.gz 4efcda7b63646eb46dabea7122fb026f2c063d2919a9dcbbffbc0929b9c56ced guix-build-84f9931cb449/output/dist-archive/bitcoin-84f9931cb449.tar.gz 1e35e96034fed00674f362d6471fb402dd2758cec2860ded4fd7e37c38935a44 guix-build-84f9931cb449/output/powerpc64-linux-gnu/SHA256SUMS.part 96a0b7f54d3b3935c134f8c2aaaf11a314b54c9d7924ba751503caa16bd1c840 guix-build-84f9931cb449/output/powerpc64-linux-gnu/bitcoin-84f9931cb449-powerpc64-linux-gnu-debug.tar.gz ae05137b6fb3494120f5413bf8a94ca3c1b0c047e1f512e6c2c5a0b1f122f075 guix-build-84f9931cb449/output/powerpc64-linux-gnu/bitcoin-84f9931cb449-powerpc64-linux-gnu.tar.gz c22e5fbcdcdbfa5d385537e2c1dab55004d9e94396ebccef0bc3d216edfacbbe guix-build-84f9931cb449/output/powerpc64le-linux-gnu/SHA256SUMS.part 52602b41e81a921435d93f2a3ae29549aa65a4147cdbf1ed7d9e4a44c4dc902a guix-build-84f9931cb449/output/powerpc64le-linux-gnu/bitcoin-84f9931cb449-powerpc64le-linux-gnu-debug.tar.gz a2cc7e9385452163a7bda99f6f9aa630fd35d4ba13d4fd9a4dd7e8062206650d guix-build-84f9931cb449/output/powerpc64le-linux-gnu/bitcoin-84f9931cb449-powerpc64le-linux-gnu.tar.gz e75fadf1b1c7e4ae3d52e7a8051a881de17bd4d9d32c1ca29ca0ddbb8028ee51 guix-build-84f9931cb449/output/riscv64-linux-gnu/SHA256SUMS.part 3b643c33842a15befb5d36d13b598a5e628c11b95671336c8dea51b5eed9c79a guix-build-84f9931cb449/output/riscv64-linux-gnu/bitcoin-84f9931cb449-riscv64-linux-gnu-debug.tar.gz e9a1ee7451502508cde73dc300aca8a421e379ac08c3f4adaf8c768fbfa942ac guix-build-84f9931cb449/output/riscv64-linux-gnu/bitcoin-84f9931cb449-riscv64-linux-gnu.tar.gz c0508a0872cf1415a47983d2ebbc9e5a46282ce7b6453afac544e0d1315b7bf9 guix-build-84f9931cb449/output/x86_64-apple-darwin/SHA256SUMS.part 7c02267cb91e2649088af5e96f81142beaad67f6a1a0588355174a4157b31458 guix-build-84f9931cb449/output/x86_64-apple-darwin/bitcoin-84f9931cb449-osx-unsigned.dmg 46dbf5a911abfa63e3c5aa8440289da5fdea89da013253c08768ce58b798a99d guix-build-84f9931cb449/output/x86_64-apple-darwin/bitcoin-84f9931cb449-osx-unsigned.tar.gz ab2e2360f18cb1b80bfd37f1a9508a938e89237767120472f932402cc809f0eb guix-build-84f9931cb449/output/x86_64-apple-darwin/bitcoin-84f9931cb449-osx64.tar.gz f58aa000692f7ea09ab8e7ec159a806d3a665f0f70558e62a53d56afb361eb02 guix-build-84f9931cb449/output/x86_64-linux-gnu/SHA256SUMS.part 78a76aef8469b07a41588e019a6dfa890c36fd5becf2c8d73a71c9e72bcabde6 guix-build-84f9931cb449/output/x86_64-linux-gnu/bitcoin-84f9931cb449-x86_64-linux-gnu-debug.tar.gz 5e6e0040b37ff035de41c8fcfee5d498bd19fa489024704dd4caa0ab9f566450 guix-build-84f9931cb449/output/x86_64-linux-gnu/bitcoin-84f9931cb449-x86_64-linux-gnu.tar.gz d6e6af70f277d9c9ef9b4773ec05920355ac07ebec71ff3e179676047329964b guix-build-84f9931cb449/output/x86_64-w64-mingw32/SHA256SUMS.part 37f24f6899e7803ed07bd0f5eb3f0fb6237ac1254dd72f446e9e4e488a927c8e guix-build-84f9931cb449/output/x86_64-w64-mingw32/bitcoin-84f9931cb449-win-unsigned.tar.gz 14f7d1c14a5fc3b4c336d301f936c5578d6e31d61ec720dfc9d4129445d1e2a2 guix-build-84f9931cb449/output/x86_64-w64-mingw32/bitcoin-84f9931cb449-win64-debug.zip c8049dcc0308a76f21dd781e8561ebbafa84034fbf8e3afa7d4017866d7fd195 guix-build-84f9931cb449/output/x86_64-w64-mingw32/bitcoin-84f9931cb449-win64-setup-unsigned.exe fb1e6580c25b073118f121aabaa04aa09643bc97cfeaea7c9a24bbe65c33cbb6 guix-build-84f9931cb449/output/x86_64-w64-mingw32/bitcoin-84f9931cb449-win64.zip ``` ACKs for top commit: hebasto: re-ACK 84f9931 Tree-SHA512: 2f5f4f6bb1f55a048dba88523f235320e51c4af963355abf6a86b7035623b2100ae3dc44396c76fbeea89ae9cfbc5342abd3e2c41760ede8b689d7757d6e7f25
2 parents 4ada742 + 84f9931 commit 711ce2e

9 files changed

+71
-654
lines changed

contrib/devtools/test-security-check.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,15 +69,15 @@ def test_PE(self):
6969
cc = determine_wellknown_cmd('CC', 'x86_64-w64-mingw32-gcc')
7070
write_testcode(source)
7171

72-
self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--no-nxcompat','-Wl,--disable-reloc-section','-Wl,--no-dynamicbase','-Wl,--no-high-entropy-va','-no-pie','-fno-PIE']),
72+
self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--disable-nxcompat','-Wl,--disable-reloc-section','-Wl,--disable-dynamicbase','-Wl,--disable-high-entropy-va','-no-pie','-fno-PIE']),
7373
(1, executable+': failed PIE DYNAMIC_BASE HIGH_ENTROPY_VA NX RELOC_SECTION CONTROL_FLOW'))
74-
self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat','-Wl,--disable-reloc-section','-Wl,--no-dynamicbase','-Wl,--no-high-entropy-va','-no-pie','-fno-PIE']),
74+
self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat','-Wl,--disable-reloc-section','-Wl,--disable-dynamicbase','-Wl,--disable-high-entropy-va','-no-pie','-fno-PIE']),
7575
(1, executable+': failed PIE DYNAMIC_BASE HIGH_ENTROPY_VA RELOC_SECTION CONTROL_FLOW'))
76-
self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat','-Wl,--enable-reloc-section','-Wl,--no-dynamicbase','-Wl,--no-high-entropy-va','-no-pie','-fno-PIE']),
76+
self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat','-Wl,--enable-reloc-section','-Wl,--disable-dynamicbase','-Wl,--disable-high-entropy-va','-no-pie','-fno-PIE']),
7777
(1, executable+': failed PIE DYNAMIC_BASE HIGH_ENTROPY_VA CONTROL_FLOW'))
78-
self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat','-Wl,--enable-reloc-section','-Wl,--no-dynamicbase','-Wl,--no-high-entropy-va','-pie','-fPIE']),
78+
self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat','-Wl,--enable-reloc-section','-Wl,--disable-dynamicbase','-Wl,--disable-high-entropy-va','-pie','-fPIE']),
7979
(1, executable+': failed PIE DYNAMIC_BASE HIGH_ENTROPY_VA CONTROL_FLOW')) # -pie -fPIE does nothing unless --dynamicbase is also supplied
80-
self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat','-Wl,--enable-reloc-section','-Wl,--dynamicbase','-Wl,--no-high-entropy-va','-pie','-fPIE']),
80+
self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat','-Wl,--enable-reloc-section','-Wl,--dynamicbase','-Wl,--disable-high-entropy-va','-pie','-fPIE']),
8181
(1, executable+': failed HIGH_ENTROPY_VA CONTROL_FLOW'))
8282
self.assertEqual(call_security_check(cc, source, executable, ['-Wl,--nxcompat','-Wl,--enable-reloc-section','-Wl,--dynamicbase','-Wl,--high-entropy-va','-pie','-fPIE']),
8383
(1, executable+': failed CONTROL_FLOW'))

contrib/guix/guix-build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ SOURCE_DATE_EPOCH="${SOURCE_DATE_EPOCH:-$(git -c log.showSignature=false log --f
239239
time-machine() {
240240
# shellcheck disable=SC2086
241241
guix time-machine --url=https://git.savannah.gnu.org/git/guix.git \
242-
--commit=aa34d4d28dfe25ba47d5800d05000fb7221788c0 \
242+
--commit=fa17abf1af09570708daa28dd40ffbc932ebe25c \
243243
--cores="$JOBS" \
244244
--keep-failed \
245245
--fallback \

contrib/guix/libexec/build.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ case "$HOST" in
109109
# 2. kernel-header-related search paths (not applicable to mingw-w64 hosts)
110110
export CROSS_C_INCLUDE_PATH="${CROSS_GCC_LIB}/include:${CROSS_GCC_LIB}/include-fixed:${CROSS_GLIBC}/include"
111111
export CROSS_CPLUS_INCLUDE_PATH="${CROSS_GCC}/include/c++:${CROSS_GCC}/include/c++/${HOST}:${CROSS_GCC}/include/c++/backward:${CROSS_C_INCLUDE_PATH}"
112-
export CROSS_LIBRARY_PATH="${CROSS_GCC_LIB_STORE}/lib:${CROSS_GCC}/${HOST}/lib:${CROSS_GCC_LIB}:${CROSS_GLIBC}/lib"
112+
export CROSS_LIBRARY_PATH="${CROSS_GCC_LIB_STORE}/lib:${CROSS_GCC_LIB}:${CROSS_GLIBC}/lib"
113113
;;
114114
*darwin*)
115115
# The CROSS toolchain for darwin uses the SDK and ignores environment variables.
@@ -126,7 +126,7 @@ case "$HOST" in
126126

127127
export CROSS_C_INCLUDE_PATH="${CROSS_GCC_LIB}/include:${CROSS_GCC_LIB}/include-fixed:${CROSS_GLIBC}/include:${CROSS_KERNEL}/include"
128128
export CROSS_CPLUS_INCLUDE_PATH="${CROSS_GCC}/include/c++:${CROSS_GCC}/include/c++/${HOST}:${CROSS_GCC}/include/c++/backward:${CROSS_C_INCLUDE_PATH}"
129-
export CROSS_LIBRARY_PATH="${CROSS_GCC_LIB_STORE}/lib:${CROSS_GCC}/${HOST}/lib:${CROSS_GCC_LIB}:${CROSS_GLIBC}/lib:${CROSS_GLIBC_STATIC}/lib"
129+
export CROSS_LIBRARY_PATH="${CROSS_GCC_LIB_STORE}/lib:${CROSS_GCC_LIB}:${CROSS_GLIBC}/lib:${CROSS_GLIBC_STATIC}/lib"
130130
;;
131131
*)
132132
exit 1 ;;

contrib/guix/manifest.scm

Lines changed: 27 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
(gnu packages gawk)
1717
(gnu packages gcc)
1818
(gnu packages gnome)
19-
(gnu packages image)
2019
(gnu packages installers)
2120
(gnu packages linux)
2221
(gnu packages llvm)
@@ -25,11 +24,11 @@
2524
(gnu packages perl)
2625
(gnu packages pkg-config)
2726
(gnu packages python)
27+
(gnu packages python-crypto)
2828
(gnu packages python-web)
2929
(gnu packages shells)
3030
(gnu packages tls)
3131
(gnu packages version-control)
32-
(guix build-system font)
3332
(guix build-system gnu)
3433
(guix build-system python)
3534
(guix build-system trivial)
@@ -79,10 +78,6 @@ http://www.linuxfromscratch.org/hlfs/view/development/chapter05/gcc-pass1.html"
7978
(("-rpath=") "-rpath-link="))
8079
#t))))))))
8180

82-
(define (make-binutils-with-mingw-w64-disable-flags xbinutils)
83-
(package-with-extra-patches xbinutils
84-
(search-our-patches "binutils-mingw-w64-disable-flags.patch")))
85-
8681
(define (make-cross-toolchain target
8782
base-gcc-for-libc
8883
base-kernel-headers
@@ -134,9 +129,7 @@ chain for " target " development."))
134129
(home-page (package-home-page xgcc))
135130
(license (package-license xgcc)))))
136131

137-
(define base-gcc
138-
(package-with-extra-patches gcc-8
139-
(search-our-patches "gcc-8-sort-libtool-find-output.patch")))
132+
(define base-gcc gcc-10)
140133

141134
;; Building glibc with stack smashing protector first landed in glibc 2.25, use
142135
;; this function to disable for older glibcs
@@ -171,7 +164,7 @@ desirable for building Bitcoin Core release binaries."
171164

172165
(define (make-mingw-pthreads-cross-toolchain target)
173166
"Create a cross-compilation toolchain package for TARGET"
174-
(let* ((xbinutils (make-binutils-with-mingw-w64-disable-flags (cross-binutils target)))
167+
(let* ((xbinutils (cross-binutils target))
175168
(pthreads-xlibc mingw-w64-x86_64-winpthreads)
176169
(pthreads-xgcc (make-gcc-with-pthreads
177170
(cross-gcc target
@@ -197,9 +190,9 @@ chain for " target " development."))
197190
(home-page (package-home-page pthreads-xgcc))
198191
(license (package-license pthreads-xgcc)))))
199192

200-
(define (make-nsis-with-sde-support base-nsis)
193+
(define (make-nsis-for-gcc-10 base-nsis)
201194
(package-with-extra-patches base-nsis
202-
(search-our-patches "nsis-SConstruct-sde-support.patch")))
195+
(search-our-patches "nsis-gcc-10-memmove.patch")))
203196

204197
(define-public lief
205198
(package
@@ -256,34 +249,6 @@ signing and timestamping. But osslsigncode is based on OpenSSL and cURL, and
256249
thus should be able to compile on most platforms where these exist.")
257250
(license license:gpl3+))) ; license is with openssl exception
258251

259-
(define-public python-asn1crypto
260-
(package
261-
(name "python-asn1crypto")
262-
(version "1.4.0")
263-
(source
264-
(origin
265-
(method git-fetch)
266-
(uri (git-reference
267-
(url "https://github.com/wbond/asn1crypto")
268-
(commit version)))
269-
(file-name (git-file-name name version))
270-
(sha256
271-
(base32
272-
"19abibn6jw20mzi1ln4n9jjvpdka8ygm4m439hplyrdfqbvgm01r"))))
273-
(build-system python-build-system)
274-
(arguments
275-
'(#:phases
276-
(modify-phases %standard-phases
277-
(replace 'check
278-
(lambda _
279-
(invoke "python" "run.py" "tests"))))))
280-
(home-page "https://github.com/wbond/asn1crypto")
281-
(synopsis "ASN.1 parser and serializer in Python")
282-
(description "asn1crypto is an ASN.1 parser and serializer with definitions
283-
for private keys, public keys, certificates, CRL, OCSP, CMS, PKCS#3, PKCS#7,
284-
PKCS#8, PKCS#12, PKCS#5, X.509 and TSP.")
285-
(license license:expat)))
286-
287252
(define-public python-elfesteem
288253
(let ((commit "87bbd79ab7e361004c98cc8601d4e5f029fd8bd5"))
289254
(package
@@ -298,7 +263,8 @@ PKCS#8, PKCS#12, PKCS#5, X.509 and TSP.")
298263
(file-name (git-file-name name commit))
299264
(sha256
300265
(base32
301-
"1nyvjisvyxyxnd0023xjf5846xd03lwawp5pfzr8vrky7wwm5maz"))))
266+
"1nyvjisvyxyxnd0023xjf5846xd03lwawp5pfzr8vrky7wwm5maz"))
267+
(patches (search-our-patches "elfsteem-value-error-python-39.patch"))))
302268
(build-system python-build-system)
303269
;; There are no tests, but attempting to run python setup.py test leads to
304270
;; PYTHONPATH problems, just disable the test
@@ -370,6 +336,8 @@ PKCS#8, PKCS#12, PKCS#5, X.509 and TSP.")
370336
(define-public python-oscryptotests
371337
(package (inherit python-oscrypto)
372338
(name "python-oscryptotests")
339+
(propagated-inputs
340+
`(("python-oscrypto" ,python-oscrypto)))
373341
(arguments
374342
`(#:tests? #f
375343
#:phases
@@ -441,16 +409,6 @@ certificates or paths. Supports various options, including: validation at a
441409
specific moment in time, whitelisting and revocation checks.")
442410
(license license:expat))))
443411

444-
(define-public python-requests-2.25.1
445-
(package (inherit python-requests)
446-
(version "2.25.1")
447-
(source (origin
448-
(method url-fetch)
449-
(uri (pypi-uri "requests" version))
450-
(sha256
451-
(base32
452-
"015qflyqsgsz09gnar69s6ga74ivq5kch69s4qxz3904m7a3v5r7"))))))
453-
454412
(define-public python-altgraph
455413
(package
456414
(name "python-altgraph")
@@ -543,7 +501,7 @@ and endian independent.")
543501
("python-oscrypto" ,python-oscrypto)
544502
("python-certvalidator" ,python-certvalidator)
545503
("python-elfesteem" ,python-elfesteem)
546-
("python-requests" ,python-requests-2.25.1)
504+
("python-requests" ,python-requests)
547505
("python-macholib" ,python-macholib)
548506
("libcrypto" ,openssl)))
549507
;; There are no tests, but attempting to run python setup.py test leads to
@@ -557,7 +515,7 @@ inspecting signatures in Mach-O binaries.")
557515

558516
(define-public glibc-2.24
559517
(package
560-
(inherit glibc)
518+
(inherit glibc-2.31)
561519
(version "2.24")
562520
(source (origin
563521
(method git-fetch)
@@ -573,9 +531,21 @@ inspecting signatures in Mach-O binaries.")
573531
"glibc-2.24-elfm-loadaddr-dynamic-rewrite.patch"
574532
"glibc-2.24-no-build-time-cxx-header-run.patch"))))))
575533

576-
(define glibc-2.27/bitcoin-patched
577-
(package-with-extra-patches glibc-2.27
578-
(search-our-patches "glibc-2.27-riscv64-Use-__has_include__-to-include-asm-syscalls.h.patch")))
534+
(define-public glibc-2.27/bitcoin-patched
535+
(package
536+
(inherit glibc-2.31)
537+
(version "2.27")
538+
(source (origin
539+
(method git-fetch)
540+
(uri (git-reference
541+
(url "https://sourceware.org/git/glibc.git")
542+
(commit "23158b08a0908f381459f273a984c6fd328363cb")))
543+
(file-name (git-file-name "glibc" "23158b08a0908f381459f273a984c6fd328363cb"))
544+
(sha256
545+
(base32
546+
"1b2n1gxv9f4fd5yy68qjbnarhf8mf4vmlxk10i3328c1w5pmp0ca"))
547+
(patches (search-our-patches "glibc-ldd-x86_64.patch"
548+
"glibc-2.27-riscv64-Use-__has_include__-to-include-asm-syscalls.h.patch"))))))
579549

580550
(packages->manifest
581551
(append
@@ -623,7 +593,7 @@ inspecting signatures in Mach-O binaries.")
623593
;; Windows
624594
(list zip
625595
(make-mingw-pthreads-cross-toolchain "x86_64-w64-mingw32")
626-
(make-nsis-with-sde-support nsis-x86_64)
596+
(make-nsis-for-gcc-10 nsis-x86_64)
627597
osslsigncode))
628598
((string-contains target "-linux-")
629599
(list (cond ((string-contains target "riscv64-")

0 commit comments

Comments
 (0)