Merge pull request #3744 from petertodd/document-isvalid-is-consensus-critical

gavinandresen · gavinandresen · commit 7be6ebcf083f · 2014-02-28T15:27:58.000-05:00
Document that CPubKey.IsValid() is consensus critical
diff --git a/src/key.h b/src/key.h
@@ -137,7 +137,9 @@ class CPubKey {
         return Hash(vch, vch+size());
     }
 
-    // just check syntactic correctness.
+    // Check syntactic correctness.
+    //
+    // Note that this is consensus critical as CheckSig() calls it!
     bool IsValid() const {
         return size() > 0;
     }

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,9 @@ class CPubKey {`
`137`	`137`	`return Hash(vch, vch+size());`
`138`	`138`	`}`
`139`	`139`
`140`		`- // just check syntactic correctness.`
	`140`	`+ // Check syntactic correctness.`
	`141`	`+ //`
	`142`	`+ // Note that this is consensus critical as CheckSig() calls it!`
`141`	`143`	`bool IsValid() const {`
`142`	`144`	`return size() > 0;`
`143`	`145`	`}`