Skip to content

Commit 7f2b9e0

Browse files
committed
Merge #10381: Shadowing warnings are not enabled by default, update doc accordingly
f203ecc Shadowing is not enabled by default, update doc accordingly. (Pavel Janík) Tree-SHA512: a7170827caa9d35457356808445ef2387fd2edde72fb76c6241cfd5decad218558b307d223e86bb66041576b638f90f6efa8a46ea6208d43da275a993617c997
2 parents a26280b + f203ecc commit 7f2b9e0

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

doc/developer-notes.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -343,10 +343,9 @@ Strings and formatting
343343
Variable names
344344
--------------
345345

346-
The shadowing warning (`-Wshadow`) is enabled by default. It prevents issues rising
347-
from using a different variable with the same name.
348-
349-
Please name variables so that their names do not shadow variables defined in the source code.
346+
Although the shadowing warning (`-Wshadow`) is not enabled by default (it prevents issues rising
347+
from using a different variable with the same name),
348+
please name variables so that their names do not shadow variables defined in the source code.
350349

351350
E.g. in member initializers, prepend `_` to the argument name shadowing the
352351
member name:

0 commit comments

Comments
 (0)