blockstorage: Let FlushChainstateBlockFile return true in case of missing cursor

fjahr · ryanofsky · fjahr · commit 82e48d20f124 · 2023-10-06T19:43:32.000+02:00
Co-authored-by: Ryan Ofsky &lt;ryan@ofsky.org&gt;
diff --git a/src/node/blockstorage.cpp b/src/node/blockstorage.cpp
@@ -767,7 +767,8 @@ bool BlockManager::FlushChainstateBlockFile(int tip_height)
     if (cursor) {
         return FlushBlockFile(cursor->file_num, /*fFinalize=*/false, /*finalize_undo=*/false);
     }
-    return false;
+    // No need to log warnings in this case.
+    return true;
 }
 
 uint64_t BlockManager::CalculateCurrentUsage()

Original file line number	Diff line number	Diff line change
`@@ -767,7 +767,8 @@ bool BlockManager::FlushChainstateBlockFile(int tip_height)`
`767`	`767`	`if (cursor) {`
`768`	`768`	`return FlushBlockFile(cursor->file_num, /fFinalize=/false, /finalize_undo=/false);`
`769`	`769`	`}`
`770`		`- return false;`
	`770`	`+ // No need to log warnings in this case.`
	`771`	`+ return true;`
`771`	`772`	`}`
`772`	`773`
`773`	`774`	`uint64_t BlockManager::CalculateCurrentUsage()`