Skip to content

Commit 83292e2

Browse files
kiminuokiminuo
committed
scripted-diff: Modify unit tests to use the ArgsManager in the BasicTestingSetup class instead of implicitly relying on gArgs.
-BEGIN VERIFY SCRIPT- git ls-files src/test/dbwrapper_tests.cpp src/test/denialofservice_tests.cpp src/test/flatfile_tests.cpp src/test/fs_tests.cpp src/test/settings_tests.cpp src/test/util_tests.cpp | xargs sed -i 's/GetDataDir()/m_args.GetDataDirPath()/g'; -END VERIFY SCRIPT-
1 parent 55c68e6 commit 83292e2

File tree

6 files changed

+19
-19
lines changed

6 files changed

+19
-19
lines changed

‎src/test/dbwrapper_tests.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ BOOST_AUTO_TEST_CASE(dbwrapper)
2626
{
2727
// Perform tests both obfuscated and non-obfuscated.
2828
for (const bool obfuscate : {false, true}) {
29-
fs::path ph = GetDataDir() / (obfuscate ? "dbwrapper_obfuscate_true" : "dbwrapper_obfuscate_false");
29+
fs::path ph = m_args.GetDataDirPath() / (obfuscate ? "dbwrapper_obfuscate_true" : "dbwrapper_obfuscate_false");
3030
CDBWrapper dbw(ph, (1 << 20), true, false, obfuscate);
3131
char key = 'k';
3232
uint256 in = InsecureRand256();
@@ -45,7 +45,7 @@ BOOST_AUTO_TEST_CASE(dbwrapper_basic_data)
4545
{
4646
// Perform tests both obfuscated and non-obfuscated.
4747
for (bool obfuscate : {false, true}) {
48-
fs::path ph = GetDataDir() / (obfuscate ? "dbwrapper_1_obfuscate_true" : "dbwrapper_1_obfuscate_false");
48+
fs::path ph = m_args.GetDataDirPath() / (obfuscate ? "dbwrapper_1_obfuscate_true" : "dbwrapper_1_obfuscate_false");
4949
CDBWrapper dbw(ph, (1 << 20), false, true, obfuscate);
5050

5151
uint256 res;
@@ -126,7 +126,7 @@ BOOST_AUTO_TEST_CASE(dbwrapper_batch)
126126
{
127127
// Perform tests both obfuscated and non-obfuscated.
128128
for (const bool obfuscate : {false, true}) {
129-
fs::path ph = GetDataDir() / (obfuscate ? "dbwrapper_batch_obfuscate_true" : "dbwrapper_batch_obfuscate_false");
129+
fs::path ph = m_args.GetDataDirPath() / (obfuscate ? "dbwrapper_batch_obfuscate_true" : "dbwrapper_batch_obfuscate_false");
130130
CDBWrapper dbw(ph, (1 << 20), true, false, obfuscate);
131131

132132
char key = 'i';
@@ -162,7 +162,7 @@ BOOST_AUTO_TEST_CASE(dbwrapper_iterator)
162162
{
163163
// Perform tests both obfuscated and non-obfuscated.
164164
for (const bool obfuscate : {false, true}) {
165-
fs::path ph = GetDataDir() / (obfuscate ? "dbwrapper_iterator_obfuscate_true" : "dbwrapper_iterator_obfuscate_false");
165+
fs::path ph = m_args.GetDataDirPath() / (obfuscate ? "dbwrapper_iterator_obfuscate_true" : "dbwrapper_iterator_obfuscate_false");
166166
CDBWrapper dbw(ph, (1 << 20), true, false, obfuscate);
167167

168168
// The two keys are intentionally chosen for ordering
@@ -202,7 +202,7 @@ BOOST_AUTO_TEST_CASE(dbwrapper_iterator)
202202
BOOST_AUTO_TEST_CASE(existing_data_no_obfuscate)
203203
{
204204
// We're going to share this fs::path between two wrappers
205-
fs::path ph = GetDataDir() / "existing_data_no_obfuscate";
205+
fs::path ph = m_args.GetDataDirPath() / "existing_data_no_obfuscate";
206206
create_directories(ph);
207207

208208
// Set up a non-obfuscated wrapper to write some initial data.
@@ -243,7 +243,7 @@ BOOST_AUTO_TEST_CASE(existing_data_no_obfuscate)
243243
BOOST_AUTO_TEST_CASE(existing_data_reindex)
244244
{
245245
// We're going to share this fs::path between two wrappers
246-
fs::path ph = GetDataDir() / "existing_data_reindex";
246+
fs::path ph = m_args.GetDataDirPath() / "existing_data_reindex";
247247
create_directories(ph);
248248

249249
// Set up a non-obfuscated wrapper to write some initial data.
@@ -278,7 +278,7 @@ BOOST_AUTO_TEST_CASE(existing_data_reindex)
278278

279279
BOOST_AUTO_TEST_CASE(iterator_ordering)
280280
{
281-
fs::path ph = GetDataDir() / "iterator_ordering";
281+
fs::path ph = m_args.GetDataDirPath() / "iterator_ordering";
282282
CDBWrapper dbw(ph, (1 << 20), true, false, false);
283283
for (int x=0x00; x<256; ++x) {
284284
uint8_t key = x;
@@ -358,7 +358,7 @@ BOOST_AUTO_TEST_CASE(iterator_string_ordering)
358358
{
359359
char buf[10];
360360

361-
fs::path ph = GetDataDir() / "iterator_string_ordering";
361+
fs::path ph = m_args.GetDataDirPath() / "iterator_string_ordering";
362362
CDBWrapper dbw(ph, (1 << 20), true, false, false);
363363
for (int x=0x00; x<10; ++x) {
364364
for (int y = 0; y < 10; y++) {
@@ -404,7 +404,7 @@ BOOST_AUTO_TEST_CASE(unicodepath)
404404
// On Windows this test will fail if the directory is created using
405405
// the ANSI CreateDirectoryA call and the code page isn't UTF8.
406406
// It will succeed if created with CreateDirectoryW.
407-
fs::path ph = GetDataDir() / "test_runner_₿_🏃_20191128_104644";
407+
fs::path ph = m_args.GetDataDirPath() / "test_runner_₿_🏃_20191128_104644";
408408
CDBWrapper dbw(ph, (1 << 20));
409409

410410
fs::path lockPath = ph / "LOCK";

‎src/test/denialofservice_tests.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ BOOST_AUTO_TEST_CASE(stale_tip_peer_management)
208208
BOOST_AUTO_TEST_CASE(peer_discouragement)
209209
{
210210
const CChainParams& chainparams = Params();
211-
auto banman = std::make_unique<BanMan>(GetDataDir() / "banlist.dat", nullptr, DEFAULT_MISBEHAVING_BANTIME);
211+
auto banman = std::make_unique<BanMan>(m_args.GetDataDirPath() / "banlist.dat", nullptr, DEFAULT_MISBEHAVING_BANTIME);
212212
auto connman = std::make_unique<CConnmanTest>(0x1337, 0x1337, *m_node.addrman);
213213
auto peerLogic = PeerManager::make(chainparams, *connman, *m_node.addrman, banman.get(),
214214
*m_node.scheduler, *m_node.chainman, *m_node.mempool, false);
@@ -302,7 +302,7 @@ BOOST_AUTO_TEST_CASE(peer_discouragement)
302302
BOOST_AUTO_TEST_CASE(DoS_bantime)
303303
{
304304
const CChainParams& chainparams = Params();
305-
auto banman = std::make_unique<BanMan>(GetDataDir() / "banlist.dat", nullptr, DEFAULT_MISBEHAVING_BANTIME);
305+
auto banman = std::make_unique<BanMan>(m_args.GetDataDirPath() / "banlist.dat", nullptr, DEFAULT_MISBEHAVING_BANTIME);
306306
auto connman = std::make_unique<CConnman>(0x1337, 0x1337, *m_node.addrman);
307307
auto peerLogic = PeerManager::make(chainparams, *connman, *m_node.addrman, banman.get(),
308308
*m_node.scheduler, *m_node.chainman, *m_node.mempool, false);

‎src/test/flatfile_tests.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ BOOST_FIXTURE_TEST_SUITE(flatfile_tests, BasicTestingSetup)
1414

1515
BOOST_AUTO_TEST_CASE(flatfile_filename)
1616
{
17-
const auto data_dir = GetDataDir();
17+
const auto data_dir = m_args.GetDataDirPath();
1818

1919
FlatFilePos pos(456, 789);
2020

@@ -27,7 +27,7 @@ BOOST_AUTO_TEST_CASE(flatfile_filename)
2727

2828
BOOST_AUTO_TEST_CASE(flatfile_open)
2929
{
30-
const auto data_dir = GetDataDir();
30+
const auto data_dir = m_args.GetDataDirPath();
3131
FlatFileSeq seq(data_dir, "a", 16 * 1024);
3232

3333
std::string line1("A purely peer-to-peer version of electronic cash would allow online "
@@ -88,7 +88,7 @@ BOOST_AUTO_TEST_CASE(flatfile_open)
8888

8989
BOOST_AUTO_TEST_CASE(flatfile_allocate)
9090
{
91-
const auto data_dir = GetDataDir();
91+
const auto data_dir = m_args.GetDataDirPath();
9292
FlatFileSeq seq(data_dir, "a", 100);
9393

9494
bool out_of_space;
@@ -108,7 +108,7 @@ BOOST_AUTO_TEST_CASE(flatfile_allocate)
108108

109109
BOOST_AUTO_TEST_CASE(flatfile_flush)
110110
{
111-
const auto data_dir = GetDataDir();
111+
const auto data_dir = m_args.GetDataDirPath();
112112
FlatFileSeq seq(data_dir, "a", 100);
113113

114114
bool out_of_space;

‎src/test/fs_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ BOOST_FIXTURE_TEST_SUITE(fs_tests, BasicTestingSetup)
1313

1414
BOOST_AUTO_TEST_CASE(fsbridge_fstream)
1515
{
16-
fs::path tmpfolder = GetDataDir();
16+
fs::path tmpfolder = m_args.GetDataDirPath();
1717
// tmpfile1 should be the same as tmpfile2
1818
fs::path tmpfile1 = tmpfolder / "fs_tests_₿_🏃";
1919
fs::path tmpfile2 = tmpfolder / "fs_tests_₿_🏃";

‎src/test/settings_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ BOOST_FIXTURE_TEST_SUITE(settings_tests, BasicTestingSetup)
4545

4646
BOOST_AUTO_TEST_CASE(ReadWrite)
4747
{
48-
fs::path path = GetDataDir() / "settings.json";
48+
fs::path path = m_args.GetDataDirPath() / "settings.json";
4949

5050
WriteText(path, R"({
5151
"string": "string",

‎src/test/util_tests.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1801,7 +1801,7 @@ static constexpr char ExitCommand = 'X';
18011801

18021802
BOOST_AUTO_TEST_CASE(test_LockDirectory)
18031803
{
1804-
fs::path dirname = GetDataDir() / "lock_dir";
1804+
fs::path dirname = m_args.GetDataDirPath() / "lock_dir";
18051805
const std::string lockname = ".lock";
18061806
#ifndef WIN32
18071807
// Revert SIGCHLD to default, otherwise boost.test will catch and fail on
@@ -1890,7 +1890,7 @@ BOOST_AUTO_TEST_CASE(test_LockDirectory)
18901890
BOOST_AUTO_TEST_CASE(test_DirIsWritable)
18911891
{
18921892
// Should be able to write to the data dir.
1893-
fs::path tmpdirname = GetDataDir();
1893+
fs::path tmpdirname = m_args.GetDataDirPath();
18941894
BOOST_CHECK_EQUAL(DirIsWritable(tmpdirname), true);
18951895

18961896
// Should not be able to write to a non-existent dir.

0 commit comments

Comments
 (0)