Skip to content

Commit 869c6e2

Browse files
committed
Merge bitcoin/bitcoin#22317: doc: Highlight DNS requests part in tor.md
86a4a15 Highlight DNS request part (Prayank) Pull request description: _What?_ Highlight DNS requests part in Proxy section _Why?_ 1. DNS requests are very important while considering privacy 2. Lot of users might skip reading it because of the way it is mixed with everything else in the doc right now 3. I have seen lot of users ignoring DNS requests or unaware of such things while using privacy tools _How?_ Initially I had tried keeping these lines separate from code block but [Jonatack didn't agree with the changes](bitcoin/bitcoin#21157 (comment)). Harding suggested using [bold/italic in `<pre></pre>`](bitcoin/bitcoin#21157 (comment)). I have used the suggestions from previous PR and added `---` This is a part of alternative described in bitcoin/bitcoin#22316 ACKs for top commit: jonatack: ACK 86a4a15 Rspigler: ACK 86a4a15 achow101: ACK 86a4a15 RiccardoMasutti: ACK 86a4a15 lsilva01: ACK bitcoin/bitcoin@86a4a15 kristapsk: ACK 86a4a15 theStack: ACK 86a4a15 Tree-SHA512: a4fe0e8c08df330e5ca78ce19ce74be7034c653f4374469d928908847a6debf385283e3a6da66de600566c7bab6290ccd35df26864aef94cbb3f294123391437
2 parents b24aa9c + 86a4a15 commit 869c6e2

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

doc/tor.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,11 @@ outgoing connections, but more is possible.
4040
-onion=ip:port Set the proxy server to use for Tor onion services. You do not
4141
need to set this if it's the same as -proxy. You can use -onion=0
4242
to explicitly disable access to onion services.
43+
------------------------------------------------------------------
4344
Note: Only the -proxy option sets the proxy for DNS requests;
4445
with -onion they will not route over Tor, so use -proxy if you
4546
have privacy concerns.
47+
------------------------------------------------------------------
4648

4749
-listen When using -proxy, listening is disabled by default. If you want
4850
to manually configure an onion service (see section 3), you'll

0 commit comments

Comments
 (0)