Merge bitcoin/bitcoin#25047: tidy: add readability-redundant-declaration

MacroFake · MacroFake · commit 880cec91fab1 · 2022-05-04T09:50:16.000+02:00
c2b2958 tidy: add readability-redundant-declaration (fanquake) Pull request description: ACKs for top commit: vincenzopalazzo: ACK bitcoin/bitcoin@c2b2958 jonatack: Review-only ACK c2b2958 Tree-SHA512: 992dd81f9d0c511efcd8d9d1a8c05fc1401b854272f28f7f31ca0922164ddd7d7c01bfcf5ca268472b5d68969137110f5c0844a52938d294750584e1a948a874
diff --git a/src/.clang-tidy b/src/.clang-tidy
@@ -1,2 +1,11 @@
-Checks:          '-*,bugprone-argument-comment,modernize-use-nullptr'
-WarningsAsErrors: 'bugprone-argument-comment,modernize-use-nullptr'
+Checks: '
+-*,
+bugprone-argument-comment,
+modernize-use-nullptr,
+readability-redundant-declaration,
+'
+WarningsAsErrors: '
+bugprone-argument-comment,
+modernize-use-nullptr,
+readability-redundant-declaration,
+'
diff --git a/src/netaddress.cpp b/src/netaddress.cpp
@@ -20,9 +20,6 @@
 #include <iterator>
 #include <tuple>
 
-constexpr size_t CNetAddr::V1_SERIALIZATION_SIZE;
-constexpr size_t CNetAddr::MAX_ADDRV2_SIZE;
-
 CNetAddr::BIP155Network CNetAddr::GetBIP155Network() const
 {
     switch (m_net) {
diff --git a/src/randomenv.cpp b/src/randomenv.cpp
@@ -57,8 +57,7 @@
 #include <sys/auxv.h>
 #endif
 
-//! Necessary on some platforms
-extern char** environ;
+extern char** environ; // NOLINT(readability-redundant-declaration): Necessary on some platforms
 
 namespace {
 

Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,6 @@`
`20`	`20`	`#include <iterator>`
`21`	`21`	`#include <tuple>`
`22`	`22`
`23`		`-constexpr size_t CNetAddr::V1_SERIALIZATION_SIZE;`
`24`		`-constexpr size_t CNetAddr::MAX_ADDRV2_SIZE;`
`25`		`-`
`26`	`23`	`CNetAddr::BIP155Network CNetAddr::GetBIP155Network() const`
`27`	`24`	`{`
`28`	`25`	`switch (m_net) {`