Skip to content

Commit 88fc795

Browse files
author
MarcoFalke
committed
Merge bitcoin/bitcoin#23267: test: bip125-replaceable in listsinceblock
b7884dd test: bip125-replaceable in listsinceblock (brunoerg) Pull request description: This PR adds test coverage for bip125-replaceable in listsinceblock. I added this test into wallet_listtransactions.py instead of putting it into wallet_listsinceblock.py to utilize the scenario already created in wallet_listtransactions.py and avoid repetition. ACKs for top commit: theStack: ACK b7884dd promag: ACK b7884dd. stratospher: tested ACK b7884dd. Verified the bip125-replaceable status of some transactions with listsinceblock. lsilva01: tACK b7884dd on Ubuntu 20.04 Tree-SHA512: 510dfe5a6f9d68e5a656514d356dc8fe99324296ed8caa78f0eb4b6c6906cf70b1fb50bde80aa6f61d726b2fa1d4ce1fe48c635ce24285588e56ceff92291617
2 parents 548ad5e + b7884dd commit 88fc795

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

test/functional/wallet_listtransactions.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,15 @@ def get_unconfirmed_utxo_entry(node, txid_to_match):
204204
assert_equal(n.gettransaction(txid_3b)["bip125-replaceable"], "yes")
205205
assert_equal(n.gettransaction(txid_4)["bip125-replaceable"], "unknown")
206206

207+
self.log.info("Test bip125-replaceable status with listsinceblock")
208+
for n in self.nodes[0:2]:
209+
txs = {tx['txid']: tx['bip125-replaceable'] for tx in n.listsinceblock()['transactions']}
210+
assert_equal(txs[txid_1], "no")
211+
assert_equal(txs[txid_2], "no")
212+
assert_equal(txs[txid_3], "yes")
213+
assert_equal(txs[txid_3b], "yes")
214+
assert_equal(txs[txid_4], "unknown")
215+
207216
self.log.info("Test mined transactions are no longer bip125-replaceable")
208217
self.generate(self.nodes[0], 1)
209218
assert txid_3b not in self.nodes[0].getrawmempool()

0 commit comments

Comments
 (0)