Skip to content

Commit 8928237

Browse files
theunifanquake
authored andcommitted
threads: fix unitialized members in sched_param
Building with gcc 8.2 against musl libc, which apparently has more attributes available in its sched_param. The following warnings were produced: warning: missing initializer for member 'sched_param::sched_ss_low_priority' [-Wmissing-field-initializers] warning: missing initializer for member 'sched_param::sched_ss_repl_period' [-Wmissing-field-initializers] warning: missing initializer for member 'sched_param::sched_ss_init_budget' [-Wmissing-field-initializers] warning: missing initializer for member 'sched_param::sched_ss_max_repl' [-Wmissing-field-initializers] Since the current thread may have interesting non-zero values for these fields, we want to be sure to only change the intended one. Query and modify the current sched_param rather than starting from a zeroed one.
1 parent 2753285 commit 8928237

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/util/system.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1293,7 +1293,7 @@ fs::path AbsPathForConfigVal(const fs::path& path, bool net_specific)
12931293
int ScheduleBatchPriority()
12941294
{
12951295
#ifdef SCHED_BATCH
1296-
const static sched_param param{0};
1296+
const static sched_param param{};
12971297
if (int ret = pthread_setschedparam(pthread_self(), SCHED_BATCH, &param)) {
12981298
LogPrintf("Failed to pthread_setschedparam: %s\n", strerror(errno));
12991299
return ret;

0 commit comments

Comments
 (0)