Skip to content

Commit 898dd9e

Browse files
author
MarcoFalke
committed
Merge bitcoin/bitcoin#22150: test: Remove unused node from feature_nulldummy
fa2b6c6 test: Remove unused node from feature_nulldummy (MarcoFalke) Pull request description: This is confusing and might even slow down the test. This reverts a change that was added a year ago in d438d60 and then the need for it was removed by 95d5d5e six months ago. Top commit has no ACKs. Tree-SHA512: 9a86792e9a634cf7bbd4e7a21b1acdfc3baba1b1962fe2b9b73848436d10351d2326dca01313c097ba2342dde7207add73e731d053c0bfa888a5d8f2b233a7cf
2 parents 8f5c9a7 + fa2b6c6 commit 898dd9e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/functional/feature_nulldummy.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828

2929
NULLDUMMY_ERROR = "non-mandatory-script-verify-flag (Dummy CHECKMULTISIG argument must be zero)"
3030

31+
3132
def trueDummy(tx):
3233
scriptSig = CScript(tx.vin[0].scriptSig)
3334
newscript = []
@@ -40,18 +41,17 @@ def trueDummy(tx):
4041
tx.vin[0].scriptSig = CScript(newscript)
4142
tx.rehash()
4243

43-
class NULLDUMMYTest(BitcoinTestFramework):
4444

45+
class NULLDUMMYTest(BitcoinTestFramework):
4546
def set_test_params(self):
46-
# Need two nodes so GBT (getblocktemplate) doesn't complain that it's not connected.
47-
self.num_nodes = 2
47+
self.num_nodes = 1
4848
self.setup_clean_chain = True
4949
# This script tests NULLDUMMY activation, which is part of the 'segwit' deployment, so we go through
5050
# normal segwit activation here (and don't use the default always-on behaviour).
5151
self.extra_args = [[
5252
f'-segwitheight={COINBASE_MATURITY + 5}',
5353
'-addresstype=legacy',
54-
]] * 2
54+
]]
5555

5656
def skip_test_if_missing_module(self):
5757
self.skip_if_no_wallet()

0 commit comments

Comments
 (0)