Skip to content

Commit 8ec7121

Browse files
author
MarcoFalke
committed
Merge #15927: [tests] log thread names by default in functional tests
7b29ec2 [tests] Comment for why logging config is set as command-line args. (John Newbery) ba534cc [tests] log thread names by default in functional tests (John Newbery) Pull request description: More detailed logs are better ACKs for commit 7b29ec: jamesob: utACK bitcoin/bitcoin@7b29ec2 Tree-SHA512: 327cfedb7b7bf32f7ce1e2de5f70c7092041a8e868e14285a79176277c6cf47ebea27027f68787332f8ad21c7f64d2640dd21813eda5b2bd0e5208a65364a879
2 parents c5ffe8d + 7b29ec2 commit 8ec7121

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

test/functional/test_framework/test_node.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,14 @@ def __init__(self, i, datadir, *, rpchost, timewait, bitcoind, bitcoin_cli, cove
8080
# For those callers that need more flexibility, they can just set the args property directly.
8181
# Note that common args are set in the config file (see initialize_datadir)
8282
self.extra_args = extra_args
83+
# Configuration for logging is set as command-line args rather than in the bitcoin.conf file.
84+
# This means that starting a bitcoind using the temp dir to debug a failed test won't
85+
# spam debug.log.
8386
self.args = [
8487
self.binary,
8588
"-datadir=" + self.datadir,
8689
"-logtimemicros",
90+
"-logthreadnames",
8791
"-debug",
8892
"-debugexclude=libevent",
8993
"-debugexclude=leveldb",

0 commit comments

Comments
 (0)