test: ensure reason is checked for invalid blocks rejection

Author: instagibbs

test/functional/data/invalid_txs.py

@@ -134,6 +134,8 @@ class BadInputOutpointIndex(BadTxTemplate):
     # Won't be rejected - nonexistent outpoint index is treated as an orphan since the coins
     # database can't distinguish between spent outpoints and outpoints which never existed.
     reject_reason = None
+    # But fails in block
+    block_reject_reason = "bad-txns-inputs-missingorspent"
     expect_disconnect = False
 
     def get_tx(self):
@@ -176,6 +178,8 @@ def get_tx(self):
 class NonexistentInput(BadTxTemplate):
     reject_reason = None  # Added as an orphan tx.
     expect_disconnect = False
+    # But fails in block
+    block_reject_reason = "bad-txns-inputs-missingorspent"
 
     def get_tx(self):
         tx = CTransaction()

test/functional/feature_block.py

@@ -161,6 +161,8 @@ def run_test(self):
             if template.valid_in_block:
                 continue
 
+            assert template.block_reject_reason or template.reject_reason
+
             self.log.info(f"Reject block with invalid tx: {TxTemplate.__name__}")
             blockname = f"for_invalid.{TxTemplate.__name__}"
             self.next_block(blockname)