wallet: remove post-migration signals connection

furszy · furszy · commit 91e065ec175e · 2024-10-21T08:29:22.000-03:00
The wallet is isolated during migration and reloaded at the end
of the process. There is no benefit on connecting the signals
few lines before unloading the wallet.
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -4275,10 +4275,6 @@ bool CWallet::ApplyMigrationData(MigrationData& data, bilingual_str& error)
     }
     local_wallet_batch.TxnCommit();
 
-    // Connect the SPKM signals
-    ConnectScriptPubKeyManNotifiers();
-    NotifyCanGetAddressesChanged();
-
     WalletLogPrintf("Wallet migration complete.\n");
 
     return true;

Original file line number	Diff line number	Diff line change
`@@ -4275,10 +4275,6 @@ bool CWallet::ApplyMigrationData(MigrationData& data, bilingual_str& error)`
`4275`	`4275`	`}`
`4276`	`4276`	`local_wallet_batch.TxnCommit();`
`4277`	`4277`
`4278`		`- // Connect the SPKM signals`
`4279`		`- ConnectScriptPubKeyManNotifiers();`
`4280`		`- NotifyCanGetAddressesChanged();`
`4281`		`-`
`4282`	`4278`	`WalletLogPrintf("Wallet migration complete.\n");`
`4283`	`4279`
`4284`	`4280`	`return true;`