Skip to content

Commit 927055e

Browse files
committed
Merge bitcoin/bitcoin#32893: doc: fix BlockConnected incorrect comment
4e69aa5 doc: fix `BlockConnected` incorrect comment (ismaelsadeeq) Pull request description: This is a simple PR that fixes the `BlockConnected` validation interface notification comment, which incorrectly states that a vector of transactions removed from the mempool is as a parameter of the method. Originally, this was the case when the method was first introduced in bitcoin/bitcoin#9725 However, the method has since changed, and this is no longer accurate. Keeping the outdated comment is now misleading. This PR removes the information about the method parameters from the docstring, aligning it with the style of other notifications methods. As noticed in this PR, comments listing parameters can become stale and go uncorrected. Therefore, this PR simply removes the inaccurate comment without listing the current returned values. ACKs for top commit: l0rinc: ACK 4e69aa5 maflcko: lgtm ACK 4e69aa5 Tree-SHA512: 3737313f7a9da55c67c78ce01bab5005946f4e1fccbb471560ff3af8c8275cb5cf876f6c53400c93f0ba1fdf134f28766ed573cbe62903127a3129ca8ce88db6
2 parents a8bff38 + 4e69aa5 commit 927055e

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/validationinterface.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ class CValidationInterface {
115115
virtual void MempoolTransactionsRemovedForBlock(const std::vector<RemovedMempoolTransactionInfo>& txs_removed_for_block, unsigned int nBlockHeight) {}
116116
/**
117117
* Notifies listeners of a block being connected.
118-
* Provides a vector of transactions evicted from the mempool as a result.
119118
*
120119
* Called on a background thread.
121120
*/

0 commit comments

Comments
 (0)