BIP341 txdata cannot be precomputed without spent outputs

sipa · sipa · commit 95f12de92505 · 2023-02-17T16:29:49.000-05:00
diff --git a/src/script/interpreter.cpp b/src/script/interpreter.cpp
@@ -1439,7 +1439,7 @@ void PrecomputedTransactionData::Init(const T& txTo, std::vector<CTxOut>&& spent
         hashOutputs = SHA256Uint256(m_outputs_single_hash);
         m_bip143_segwit_ready = true;
     }
-    if (uses_bip341_taproot) {
+    if (uses_bip341_taproot && m_spent_outputs_ready) {
         m_spent_amounts_single_hash = GetSpentAmountsSHA256(m_spent_outputs);
         m_spent_scripts_single_hash = GetSpentScriptsSHA256(m_spent_outputs);
         m_bip341_taproot_ready = true;

Original file line number	Diff line number	Diff line change
`@@ -1439,7 +1439,7 @@ void PrecomputedTransactionData::Init(const T& txTo, std::vector<CTxOut>&& spent`
`1439`	`1439`	`hashOutputs = SHA256Uint256(m_outputs_single_hash);`
`1440`	`1440`	`m_bip143_segwit_ready = true;`
`1441`	`1441`	`}`
`1442`		`- if (uses_bip341_taproot) {`
	`1442`	`+ if (uses_bip341_taproot && m_spent_outputs_ready) {`
`1443`	`1443`	`m_spent_amounts_single_hash = GetSpentAmountsSHA256(m_spent_outputs);`
`1444`	`1444`	`m_spent_scripts_single_hash = GetSpentScriptsSHA256(m_spent_outputs);`
`1445`	`1445`	`m_bip341_taproot_ready = true;`