add orphanage byte accounting to TxDownloadManagerImpl::CheckIsEmpty()

glozow · glozow · commit 982ce1017816 · 2025-02-06T15:45:30.000-05:00
diff --git a/src/node/txdownloadman_impl.cpp b/src/node/txdownloadman_impl.cpp
@@ -578,9 +578,11 @@ CTransactionRef TxDownloadManagerImpl::GetTxToReconsider(NodeId nodeid)
 void TxDownloadManagerImpl::CheckIsEmpty(NodeId nodeid)
 {
     assert(m_txrequest.Count(nodeid) == 0);
+    assert(m_orphanage.UsageByPeer(nodeid) == 0);
 }
 void TxDownloadManagerImpl::CheckIsEmpty()
 {
+    assert(m_orphanage.TotalOrphanUsage() == 0);
     assert(m_orphanage.Size() == 0);
     assert(m_txrequest.Size() == 0);
     assert(m_num_wtxid_peers == 0);

Original file line number	Diff line number	Diff line change
`@@ -578,9 +578,11 @@ CTransactionRef TxDownloadManagerImpl::GetTxToReconsider(NodeId nodeid)`
`578`	`578`	`void TxDownloadManagerImpl::CheckIsEmpty(NodeId nodeid)`
`579`	`579`	`{`
`580`	`580`	`assert(m_txrequest.Count(nodeid) == 0);`
	`581`	`+ assert(m_orphanage.UsageByPeer(nodeid) == 0);`
`581`	`582`	`}`
`582`	`583`	`void TxDownloadManagerImpl::CheckIsEmpty()`
`583`	`584`	`{`
	`585`	`+ assert(m_orphanage.TotalOrphanUsage() == 0);`
`584`	`586`	`assert(m_orphanage.Size() == 0);`
`585`	`587`	`assert(m_txrequest.Size() == 0);`
`586`	`588`	`assert(m_num_wtxid_peers == 0);`