Skip to content

Commit 9912486

Browse files
rpc: Make HTTP RPC debug logging more informative
1 parent 76ae7a1 commit 9912486

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/httpserver.cpp

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,21 +224,25 @@ static void http_request_cb(struct evhttp_request* req, void* arg)
224224
}
225225
std::unique_ptr<HTTPRequest> hreq(new HTTPRequest(req));
226226

227-
LogPrint(BCLog::HTTP, "Received a %s request for %s from %s\n",
228-
RequestMethodString(hreq->GetRequestMethod()), hreq->GetURI(), hreq->GetPeer().ToString());
229-
230227
// Early address-based allow check
231228
if (!ClientAllowed(hreq->GetPeer())) {
229+
LogPrint(BCLog::HTTP, "HTTP request from %s rejected: Client network is not allowed RPC access\n",
230+
hreq->GetPeer().ToString());
232231
hreq->WriteReply(HTTP_FORBIDDEN);
233232
return;
234233
}
235234

236235
// Early reject unknown HTTP methods
237236
if (hreq->GetRequestMethod() == HTTPRequest::UNKNOWN) {
237+
LogPrint(BCLog::HTTP, "HTTP request from %s rejected: Unknown HTTP request method\n",
238+
hreq->GetPeer().ToString());
238239
hreq->WriteReply(HTTP_BADMETHOD);
239240
return;
240241
}
241242

243+
LogPrint(BCLog::HTTP, "Received a %s request for %s from %s\n",
244+
RequestMethodString(hreq->GetRequestMethod()), SanitizeString(hreq->GetURI()).substr(0, 100), hreq->GetPeer().ToString());
245+
242246
// Find registered handler for prefix
243247
std::string strURI = hreq->GetURI();
244248
std::string path;

0 commit comments

Comments
 (0)