fuzz: Clarify Apple-Clang-16 workaround

MarcoFalke · MarcoFalke · commit 9999dbc1bd17 · 2024-06-26T18:48:27.000+02:00
diff --git a/src/test/fuzz/fuzz.cpp b/src/test/fuzz/fuzz.cpp
@@ -72,8 +72,8 @@ auto& FuzzTargets()
 
 void FuzzFrameworkRegisterTarget(std::string_view name, TypeTestOneInput target, FuzzTargetOptions opts)
 {
-    const auto it_ins{FuzzTargets().try_emplace(name, FuzzTarget /* temporary can be dropped after clang-16 */ {std::move(target), std::move(opts)})};
-    Assert(it_ins.second);
+    const auto [it, ins]{FuzzTargets().try_emplace(name, FuzzTarget /* temporary can be dropped after Apple-Clang-16 ? */ {std::move(target), std::move(opts)})};
+    Assert(ins);
 }
 
 static std::string_view g_fuzz_target;

Original file line number	Diff line number	Diff line change
`@@ -72,8 +72,8 @@ auto& FuzzTargets()`
`72`	`72`
`73`	`73`	`void FuzzFrameworkRegisterTarget(std::string_view name, TypeTestOneInput target, FuzzTargetOptions opts)`
`74`	`74`	`{`
`75`		`- const auto it_ins{FuzzTargets().try_emplace(name, FuzzTarget /* temporary can be dropped after clang-16 */ {std::move(target), std::move(opts)})};`
`76`		`- Assert(it_ins.second);`
	`75`	`+ const auto [it, ins]{FuzzTargets().try_emplace(name, FuzzTarget /* temporary can be dropped after Apple-Clang-16 ? */ {std::move(target), std::move(opts)})};`
	`76`	`+ Assert(ins);`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`static std::string_view g_fuzz_target;`