Skip to content

Commit 9ba5688

Browse files
committed
Merge bitcoin/bitcoin#30869: ci: Print inner env, Make ccache config more flexible
fa99e45 ci: Allow CCACHE_DIR bind mount (MarcoFalke) fa252da ci: Remove hardcoded CCACHE_DIR in cirrus (MarcoFalke) fa14690 ci: Bump default CCACHE_MAXSIZE to 500M (MarcoFalke) aaaa7cf cirrus: Drop CCACHE_NOHASHDIR (MarcoFalke) fa7ca18 ci: Print inner env (MarcoFalke) Pull request description: The outer env is printed when the `/tmp/env-$USER-$CONTAINER_NAME` is created. There is also a separate env printed when building the container image (usually with default values). To confirm that the inner container env is correctly derived from the outer env, and not from the default build env, print it a third time. ACKs for top commit: l0rinc: utACK fa99e45 willcl-ark: ACK fa99e45 Tree-SHA512: 59fd3262d551e09224866e31c14ca865461e81abbe00b83391fe3a9c7ada30fd2fd0272e4aa812df2712433ac7594d1a55cf674248b341359cec09c8d3f0c58b
2 parents ab0b570 + fa99e45 commit 9ba5688

11 files changed

+14
-12
lines changed

.cirrus.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ env: # Global defaults
44
MAKEJOBS: "-j10"
55
TEST_RUNNER_PORT_MIN: "14000" # Must be larger than 12321, which is used for the http cache. See https://cirrus-ci.org/guide/writing-tasks/#http-cache
66
CI_FAILFAST_TEST_LEAVE_DANGLING: "1" # Cirrus CI does not care about dangling processes and setting this variable avoids killing the CI script itself on error
7-
CCACHE_MAXSIZE: "200M"
8-
CCACHE_DIR: "/tmp/ccache_dir"
9-
CCACHE_NOHASHDIR: "1" # Debug info might contain a stale path if the build dir changes, but this is fine
107

118
# A self-hosted machine(s) can be used via Cirrus CI. It can be configured with
129
# multiple users to run tasks in parallel. No sudo permission is required.

ci/test/00_setup_env.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,12 @@ export RUN_FUZZ_TESTS=${RUN_FUZZ_TESTS:-false}
5353
export BOOST_TEST_RANDOM=${BOOST_TEST_RANDOM:-1}
5454
# See man 7 debconf
5555
export DEBIAN_FRONTEND=noninteractive
56-
export CCACHE_MAXSIZE=${CCACHE_MAXSIZE:-100M}
56+
export CCACHE_MAXSIZE=${CCACHE_MAXSIZE:-500M}
5757
export CCACHE_TEMPDIR=${CCACHE_TEMPDIR:-/tmp/.ccache-temp}
5858
export CCACHE_COMPRESS=${CCACHE_COMPRESS:-1}
5959
# The cache dir.
6060
# This folder exists only on the ci guest, and on the ci host as a volume.
61-
export CCACHE_DIR=${CCACHE_DIR:-$BASE_SCRATCH_DIR/.ccache}
61+
export CCACHE_DIR="${CCACHE_DIR:-$BASE_SCRATCH_DIR/ccache}"
6262
# Folder where the build result is put (bin and lib).
6363
export BASE_OUTDIR=${BASE_OUTDIR:-$BASE_SCRATCH_DIR/out}
6464
# The folder for previous release binaries.

ci/test/00_setup_env_mac_native.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,4 @@ export BITCOIN_CONFIG="-DBUILD_GUI=ON -DWITH_ZMQ=ON -DWITH_MINIUPNPC=ON -DWITH_N
1515
export CI_OS_NAME="macos"
1616
export NO_DEPENDS=1
1717
export OSX_SDK=""
18-
export CCACHE_MAXSIZE=400M
1918
export RUN_FUZZ_TESTS=true

ci/test/00_setup_env_native_asan.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,3 @@ export BITCOIN_CONFIG="\
3232
-DAPPEND_CXXFLAGS='-std=c++23' \
3333
-DAPPEND_CPPFLAGS='-DARENA_DEBUG -DDEBUG_LOCKORDER' \
3434
"
35-
export CCACHE_MAXSIZE=300M

ci/test/00_setup_env_native_fuzz.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,4 @@ export BITCOIN_CONFIG="\
2323
-DCMAKE_C_FLAGS='-ftrivial-auto-var-init=pattern' \
2424
-DCMAKE_CXX_FLAGS='-ftrivial-auto-var-init=pattern' \
2525
"
26-
export CCACHE_MAXSIZE=200M
2726
export LLVM_SYMBOLIZER_PATH="/usr/bin/llvm-symbolizer-18"

ci/test/00_setup_env_native_fuzz_with_msan.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,3 @@ export USE_MEMORY_SANITIZER="true"
3131
export RUN_UNIT_TESTS="false"
3232
export RUN_FUNCTIONAL_TESTS="false"
3333
export RUN_FUZZ_TESTS=true
34-
export CCACHE_MAXSIZE=250M

ci/test/00_setup_env_native_fuzz_with_valgrind.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,3 @@ export BITCOIN_CONFIG="\
2121
-DCMAKE_C_COMPILER=clang-16 \
2222
-DCMAKE_CXX_COMPILER=clang++-16 \
2323
"
24-
export CCACHE_MAXSIZE=200M

ci/test/00_setup_env_native_msan.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,3 @@ export BITCOIN_CONFIG="\
2828
"
2929
export USE_MEMORY_SANITIZER="true"
3030
export RUN_FUNCTIONAL_TESTS="false"
31-
export CCACHE_MAXSIZE=250M

ci/test/00_setup_env_native_tidy.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,3 @@ export BITCOIN_CONFIG="\
2525
-DCMAKE_C_FLAGS_RELWITHDEBINFO='-O0 -g0' \
2626
-DCMAKE_CXX_FLAGS_RELWITHDEBINFO='-O0 -g0' \
2727
"
28-
export CCACHE_MAXSIZE=200M

ci/test/02_run_container.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,14 @@ if [ -z "$DANGER_RUN_CI_ON_HOST" ]; then
4848
CI_PREVIOUS_RELEASES_MOUNT="type=bind,src=${PREVIOUS_RELEASES_DIR},dst=$PREVIOUS_RELEASES_DIR"
4949
fi
5050

51+
if [ "$DANGER_CI_ON_HOST_CCACHE_FOLDER" ]; then
52+
if [ ! -d "${CCACHE_DIR}" ]; then
53+
echo "Error: Directory '${CCACHE_DIR}' must be created in advance."
54+
exit 1
55+
fi
56+
CI_CCACHE_MOUNT="type=bind,src=${CCACHE_DIR},dst=${CCACHE_DIR}"
57+
fi
58+
5159
docker network create --ipv6 --subnet 1111:1111::/112 ci-ip6net || true
5260

5361
if [ -n "${RESTART_CI_DOCKER_BEFORE_RUN}" ] ; then

0 commit comments

Comments
 (0)