Merge #15327: tests: Make test updatecoins_simulation_test deterministic

MarcoFalke · MarcoFalke · commit 9e7f8f6c8271 · 2019-02-05T17:14:30.000-05:00
ef0b012 tests: Make updatecoins_simulation_test deterministic (practicalswift) Pull request description: Make test `updatecoins_simulation_test` deterministic. Can be verified using `contrib/test_deterministic_coverage.sh` introduced in #15296. Related: * #15296: "tests: Add script checking for deterministic line coverage in unit tests" * #15324: "test: Make bloom tests deterministic" * #14343: "coverage reports non-deterministic" Tree-SHA512: 3466e28a42dd3735effb8542044d88e8350a470729d4a4f02abce9d6367de6568d698131469ba154d3dc76d448bacb360b7aefd066bb5b91408c0be375dd3ecb
diff --git a/src/test/coins_tests.cpp b/src/test/coins_tests.cpp
@@ -279,6 +279,8 @@ UtxoData::iterator FindRandomFrom(const std::set<COutPoint> &utxoSet) {
 // has the expected effect (the other duplicate is overwritten at all cache levels)
 BOOST_AUTO_TEST_CASE(updatecoins_simulation_test)
 {
+    SeedInsecureRand(/* deterministic */ true);
+
     bool spent_a_duplicate_coinbase = false;
     // A simple map to track what we expect the cache stack to represent.
     std::map<COutPoint, Coin> result;

Original file line number	Diff line number	Diff line change
`@@ -279,6 +279,8 @@ UtxoData::iterator FindRandomFrom(const std::set<COutPoint> &utxoSet) {`
`279`	`279`	`// has the expected effect (the other duplicate is overwritten at all cache levels)`
`280`	`280`	`BOOST_AUTO_TEST_CASE(updatecoins_simulation_test)`
`281`	`281`	`{`
	`282`	`+ SeedInsecureRand(/* deterministic */ true);`
	`283`	`+`
`282`	`284`	`bool spent_a_duplicate_coinbase = false;`
`283`	`285`	`// A simple map to track what we expect the cache stack to represent.`
`284`	`286`	`std::map<COutPoint, Coin> result;`