Skip to content

Commit 9ec30db

Browse files
committed
Merge bitcoin/bitcoin#27418: test: Remove windows workaround in authproxy
fa584b4 test: Remove windows workaround in authproxy (MarcoFalke) Pull request description: I wonder if the windows issues have also been fixed by bumping the server timeout in commit 88134fc. I guess the only way to find out and try. Note that even with the workaround, the issue would still happen occasionally: bitcoin/bitcoin#18623 ACKs for top commit: fanquake: ACK fa584b4 Tree-SHA512: 1c633d7d8b54fa47bb851457d48b7d80bf6d6ea353db80610231e0bd385061b795f97ea2b64022fa24e79b4d7dcb5e947e0d637da228f10998e950d84b920878
2 parents 27ad26d + fa584b4 commit 9ec30db

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

test/functional/test_framework/authproxy.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import http.client
4040
import json
4141
import logging
42-
import os
4342
import socket
4443
import time
4544
import urllib.parse
@@ -100,11 +99,6 @@ def _request(self, method, path, postdata):
10099
'User-Agent': USER_AGENT,
101100
'Authorization': self.__auth_header,
102101
'Content-type': 'application/json'}
103-
if os.name == 'nt':
104-
# Windows somehow does not like to re-use connections
105-
# TODO: Find out why the connection would disconnect occasionally and make it reusable on Windows
106-
# Avoid "ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine"
107-
self._set_conn()
108102
self.__conn.request(method, path, postdata, headers)
109103
return self._get_response()
110104

0 commit comments

Comments
 (0)