Commit a04f17a
committed
doc: warn that CheckBlock() underestimates sigops
Counting sigops in the witness and for p2sh requires
context that CheckBlock() does not have, so it only
counts a subset of sigops.
The check here was introduced by Satoshi as a "cleanup" in
f1e1fb4. With the attempted
introduction of OP_EVAL, it was replaced by the check in
ConnectBlock(). Commit e679ec9
marked this code as a placeholder for backward compatibility.
Then when P2SH replaced OP_EVAL in 922e8e2
the phrase "compatibility-breaking" was replaced by a simple
observation that before v0.6 this is how sigops were counted.
It's unclear why the check was kept and there were no review comments
about it.1 parent 66aa6a4 commit a04f17a
1 file changed
+2
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4094 | 4094 | | |
4095 | 4095 | | |
4096 | 4096 | | |
| 4097 | + | |
| 4098 | + | |
4097 | 4099 | | |
4098 | 4100 | | |
4099 | 4101 | | |
| |||
0 commit comments