Skip to content

Commit a27253d

Browse files
committed
pull-tester.py: Re-enable coverage msg, new args to run test script
1 parent 47b9374 commit a27253d

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

qa/pull-tester/pull-tester.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,12 @@ def commentOn(commentUrl, success, inMerge, needTests, linkUrl):
6767
auth=(os.environ['GITHUB_USER'], os.environ["GITHUB_AUTH_TOKEN"]))
6868

6969
if success == True:
70-
post_data = { "body" : "Automatic sanity-testing: PASSED, see " + linkUrl + " for binaries and test log." + common_message}
70+
if needTests:
71+
message = "Automatic sanity-testing: PLEASE ADD TEST-CASES, though technically passed. See " + linkUrl + " for binaries and test log."
72+
else:
73+
message = "Automatic sanity-testing: PASSED, see " + linkUrl + " for binaries and test log."
74+
75+
post_data = { "body" : message + common_message}
7176
elif inMerge:
7277
post_data = { "body" : "Automatic sanity-testing: FAILED MERGE, see " + linkUrl + " for test log." + """
7378
@@ -113,7 +118,7 @@ def testpull(number, comment_url, clone_url, commit):
113118
run("chown -R ${BUILD_USER}:${BUILD_GROUP} ${CHROOT_COPY}/${OUT_DIR}", fail_hard=False)
114119

115120
script = os.environ["BUILD_PATH"]+"/qa/pull-tester/pull-tester.sh"
116-
script += " ${BUILD_PATH} ${MINGW_DEPS_DIR} ${SCRIPTS_DIR}/BitcoindComparisonTool.jar 6 ${OUT_DIR}"
121+
script += " ${BUILD_PATH} ${MINGW_DEPS_DIR} ${SCRIPTS_DIR}/BitcoindComparisonTool_jar/BitcoindComparisonTool.jar 0 6 ${OUT_DIR}"
117122
returncode = run("chroot ${CHROOT_COPY} sudo -u ${BUILD_USER} -H timeout ${TEST_TIMEOUT} "+script,
118123
fail_hard=False, stdout=out, stderr=out)
119124

0 commit comments

Comments
 (0)