Skip to content

Commit a40ccbb

Browse files
committed
Merge #16858: Qt: advise users not to switch wallets when opening a BIP70 URI.
1153caf Qt: advise users not to switch wallets when opening a BIP70 URI. (James Hilliard) Pull request description: It would probably be a good idea to have something like this before #15584 is merged. ACKs for top commit: jonasschnelli: utACK 1153caf fanquake: ACK 1153caf Tree-SHA512: 6e682dd280c44eaafb1206c32439df42a20173c33297bf93dd607f0a7a2faec8e2d17fff83c85027083ebd11a71795b443e707992251574370dd1d46b7bff060
2 parents 4bfef0d + 1153caf commit a40ccbb

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/qt/paymentserver.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,9 @@ void PaymentServer::handleURIOrFile(const QString& s)
328328
#ifndef ENABLE_BIP70
329329
if (uri.hasQueryItem("r")) { // payment request
330330
Q_EMIT message(tr("URI handling"),
331-
tr("Cannot process payment request because BIP70 support was not compiled in."),
331+
tr("Cannot process payment request because BIP70 support was not compiled in.")+
332+
tr("Due to widespread security flaws in BIP70 it's strongly recommended that any merchant instructions to switch wallets be ignored.")+
333+
tr("If you are receiving this error you should request the merchant provide a BIP21 compatible URI."),
332334
CClientUIInterface::ICON_WARNING);
333335
}
334336
#endif
@@ -364,7 +366,9 @@ void PaymentServer::handleURIOrFile(const QString& s)
364366
return;
365367
#else
366368
Q_EMIT message(tr("Payment request file handling"),
367-
tr("Cannot process payment request because BIP70 support was not compiled in."),
369+
tr("Cannot process payment request because BIP70 support was not compiled in.")+
370+
tr("Due to widespread security flaws in BIP70 it's strongly recommended that any merchant instructions to switch wallets be ignored.")+
371+
tr("If you are receiving this error you should request the merchant provide a BIP21 compatible URI."),
368372
CClientUIInterface::ICON_WARNING);
369373
#endif
370374
}

0 commit comments

Comments
 (0)