Merge bitcoin/bitcoin#31497: Remove unused variable assignment

achow101 · achow101 · commit ad174c281758 · 2024-12-30T13:22:31.000-05:00
b9766c9 Remove unused variable assignment (yancy) Pull request description: The variable is conditionally assigned toward the end of the loop and not used after. It's then set back to its default value at the beginning of the loop. ACKs for top commit: theuni: utACK b9766c9 achow101: ACK b9766c9 hodlinator: crACK b9766c9 danielabrozzoni: code review ACK b9766c9 murchandamus: ACK b9766c9 Tree-SHA512: 45e62b0dd561a473f5ae21bfa91db494940b752886669c85b63a83b68d2a157a301e9450082635e921f3dc812e6307f4ad1674806b74b3e7e0f9f4db543ad93d
diff --git a/src/wallet/coinselection.cpp b/src/wallet/coinselection.cpp
@@ -478,7 +478,6 @@ util::Result<SelectionResult> CoinGrinder(std::vector<OutputGroup>& utxo_pool, c
             // Neither adding to the current selection nor exploring the omission branch of the last selected UTXO can
             // find any solutions. Redirect to exploring the Omission branch of the penultimate selected UTXO (i.e.
             // set `next_utxo` to one after the penultimate selected, then deselect the last two selected UTXOs)
-            should_cut = false;
             deselect_last();
             should_shift  = true;
         }

Original file line number	Diff line number	Diff line change
`@@ -478,7 +478,6 @@ util::Result<SelectionResult> CoinGrinder(std::vector<OutputGroup>& utxo_pool, c`
`478`	`478`	`// Neither adding to the current selection nor exploring the omission branch of the last selected UTXO can`
`479`	`479`	`// find any solutions. Redirect to exploring the Omission branch of the penultimate selected UTXO (i.e.`
`480`	`480`	// set `next_utxo` to one after the penultimate selected, then deselect the last two selected UTXOs)
`481`		`- should_cut = false;`
`482`	`481`	`deselect_last();`
`483`	`482`	`should_shift = true;`
`484`	`483`	`}`