Skip to content

Commit aeac68d

Browse files
committed
net: don't check if the socket is valid in GetBindAddress()
The socket is always valid (the underlying file descriptor is not `INVALID_SOCKET`) when `GetBindAddress()` is called.
1 parent 5ac1a51 commit aeac68d

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/net.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -427,12 +427,10 @@ static CAddress GetBindAddress(const Sock& sock)
427427
CAddress addr_bind;
428428
struct sockaddr_storage sockaddr_bind;
429429
socklen_t sockaddr_bind_len = sizeof(sockaddr_bind);
430-
if (sock.Get() != INVALID_SOCKET) {
431-
if (!sock.GetSockName((struct sockaddr*)&sockaddr_bind, &sockaddr_bind_len)) {
432-
addr_bind.SetSockAddr((const struct sockaddr*)&sockaddr_bind);
433-
} else {
434-
LogPrintLevel(BCLog::NET, BCLog::Level::Warning, "getsockname failed\n");
435-
}
430+
if (!sock.GetSockName((struct sockaddr*)&sockaddr_bind, &sockaddr_bind_len)) {
431+
addr_bind.SetSockAddr((const struct sockaddr*)&sockaddr_bind);
432+
} else {
433+
LogPrintLevel(BCLog::NET, BCLog::Level::Warning, "getsockname failed\n");
436434
}
437435
return addr_bind;
438436
}

0 commit comments

Comments
 (0)